Repository navigation
Conversation
Author
|
When you have time, could a maintainer review the TCP address-family fix for #827 and approve the pending CI run? I saw the maintenance notice and understand review may take time. Thanks. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Prevents an IPv6-only wildcard listener from satisfying an IPv4 socket check in the Linux ss backend.
For TCP, ss distinguishes an IPv6-only listener (
[::]:port) from a dual-stack listener (*:port). The parser already expands the dual-stack form into both families. The inherited matcher nevertheless treats any IPv6 wildcard as enough, even for an explicit IPv4 spec.The Linux ss backend now matches wildcards to the requested address family. A host-less spec requires both wildcard families, as documented. Exact-address and Unix-socket checks are preserved. Netstat and BSD behavior is unchanged.
Issue
Partially addresses #827: verified for TCP on Linux with iproute2 5.15.
UDP is not fully fixed: this ss version prints
*for both IPv6-only and dual-stack UDP sockets, so the existing parser cannot distinguish them. Older ss wildcard ambiguity from #389 is also outside this patch.Validation