Repository navigation
Conversation
mabunemeh
force-pushed
the
openstacksdk-hooks
branch
from
November 22, 2026 17:21
3263bc6 to
b3362b0
Compare
Member
|
|
openstacksdk-based applications cannot be frozen without these: * openstack/version.py and os_service_types/__init__.py read their distribution metadata through pbr at import time, so freezing without the metadata raises on import. * openstack.config loads defaults.json and its schemas from the package directory, openstack.config.vendors globs the vendor profiles (JSON and YAML) from config/vendors/, and os_service_types loads its service-type authority from a JSON data file. A missing vendor profile is silently ignored, so the whole config directory is collected. * Service proxies are resolved by service type and microversion, and keystoneauth1 loads auth plugins through stevedore from the keystoneauth1.plugin entry-point namespace, so neither is reachable by static analysis. The test suites and keystoneauth1.fixture (which needs the optional fixtures library) are excluded from the collected submodules.
Contributor
Author
|
Thanks, you're right — since a rejected subpackage is never queued, nothing under it can reach the filter. I've reduced both filters to plain name checks ( |
mabunemeh
force-pushed
the
openstacksdk-hooks
branch
from
November 22, 2026 18:30
b3362b0 to
3715826
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
openstacksdk-based applications currently cannot be frozen: the resulting
binary either fails on import or misbehaves at run-time. Three mechanisms
defeat static analysis:
openstack/version.pycallspbr.version.VersionInfo('openstacksdk')andos_service_types/__init__.pycallspbr.version.VersionInfo('os-service-types'), both of which read theinstalled distribution metadata, so importing the package raises without it.
openstack.configloadsconfig/defaults.jsonand its schemas from the package directory, andopenstack.config.vendorsglobs the vendor profiles (*.jsonand*.yaml)from
config/vendors/. A missing vendor profile is silently ignored, so aclouds.yamlwithprofile: ovhquietly loses its defaults. The hooktherefore collects the whole
configdirectory.os_service_typesloads theservice-type authority from
data/service-types.json.and microversion at run-time, and keystoneauth1 loads its auth plugins
through stevedore from the
keystoneauth1.pluginentry-point namespace(26 entry points in 5.19.0).
The test suites are excluded from the collected submodules, as is
keystoneauth1.fixture, which imports the optionalfixtureslibrary andotherwise emits a build warning.
The tests cover the pbr version lookups,
defaults.json, a JSON and a YAMLvendor profile, a service proxy, two stevedore-loaded auth plugins and the
service-type authority. All three packages now require Python >= 3.11, so the
pins carry that marker.
Validation:
openstack raises
PackageNotFoundErrorforopenstacksdk(pbr versionlookup), keystoneauth1 raises
ModuleNotFoundError: No module named 'keystoneauth1.loading._plugins',and os_service_types raises
FileNotFoundErrorforos_service_types/data/service-types.json.config/vendorscollection, thetest_openstacksdkonedir andonefile builds fail at
vendors.get_profile('ovh').Windows/Python 3.14 with PyInstaller 6.22.3, openstacksdk 4.24.0,
keystoneauth1 5.19.0 and os-service-types 1.9.0.
3.14 and PyInstaller 6.22.3, 6 passed and none skipped on each platform.
Cross-platform CI: https://github.com/mabunemeh/pyinstaller-hooks-contrib/actions/runs/45048555080