Repository navigation
Fix error messages in label and exemplar validation - #1236
Open
caiotheodoro wants to merge 1 commit into
Open
caiotheodoro wants to merge 1 commit into
caiotheodoro wants to merge 1 commit into
Conversation
The exemplar length error never interpolated its %d placeholder, and the reserved label error read "Reserved label methe fric name" since prometheus#1070. Signed-off-by: Caio Theodoro <48462974+caiotheodoro@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_validate_exemplarraisesExemplar labels have %d UTF-8 characters, exceeding the limit of 128without ever filling in the placeholder, soCounter('c', 'h').inc(exemplar={'a': 'x' * 129})reports a literal%d. It now reports the count._validate_labelnamesraisesReserved label methe fric name: leforHistogram(..., labelnames=['le'])andSummary(..., labelnames=['quantile']). The typo came in with #1070; before that it readReserved label metric name. Restored.The four affected tests now assert on the message and fail on the old source. Full suite: 428 passed, 14 skipped.
@csmarchbanks
Drafted with Claude Sonnet 5.5. Reviewed by Muse Spark 1.3 and GLM 5.3 as judges before submission.