Repository navigation
Conversation
PostgreSQL adds ::text to varchar partial-index predicates. Treat the normalized identifier form as equal to Prisma's generated form. Fixes prisma/orm#29386
Summary by CodeRabbit
WalkthroughThe PostgreSQL schema differ now treats identifier and compound-identifier expressions with equivalent 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix PostgreSQL partial-index migration drift for
@db.VarCharfields.This directly fixes prisma/orm#29386.
PostgreSQL normalizes partial-index predicates by adding
::textcaststo
VARCHARcolumn identifiers and string literals. The schema differpreviously handled the literal cast but not the identifier cast, so
migrate devrepeatedly generated a no-op drop/create-index migration.The predicate comparator now treats an identifier and its implicit
::textform as equivalent. Other casts remain significant.Fixes prisma/orm#29386
Test
Added a PostgreSQL regression test that creates a migration for a
partial unique index on
VARCHARfields, then verifies an unchangedschema does not create a second migration.
Ran:
cargo test -p sql-migration-tests --test migration_tests -- --nocaptureAI assistance
AI assistance was used to investigate the PostgreSQL predicate normalization
and draft the regression test. The implementation and test result were
reviewed and verified locally.