Skip to content

Run tests on PHP 8.6 as well - #215

Closed
spaze wants to merge 1 commit into
paragonie:masterfrom
spaze:spaze/php-8.6-tests
Closed

spaze wants to merge 1 commit into
paragonie:masterfrom
spaze:spaze/php-8.6-tests

Conversation

@spaze

@spaze spaze commented Nov 6, 2026

Copy link
Copy Markdown
Contributor

PHP 8.6 is coming soon.

Copilot AI balanced review requested due to automatic review settings November 6, 2026 20:53
@spaze
spaze marked this pull request as draft November 6, 2026 20:54

This comment was marked as spam.

@paragonie-security

Copy link
Copy Markdown
Contributor

Please don't point AI tools at our repositories.

@spaze

spaze commented Nov 6, 2026

Copy link
Copy Markdown
Contributor Author

@paragonie-security This wasn't AI being pointed at the repo, but seems like my Copilot ran the review automatically, sorry for that.

@paragonie-security

paragonie-security commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

It happens. I don't care if other people use AI, but when it starts leaving comments or reviews on our PRs, it clutters up our inbox. We've tried to disable Copilot access (insofar as GitHub allows us to) to minimize it, but it still happens occasionally.

@spaze

spaze commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor Author

I understand, but it wasn't intentional, I haven't asked Copilot to review the PR - that would be (and was) just plain token burning :-) But sometimes it just does it no matter if it's selected in Reviewers or not, I haven't figured out when or why (update: seems that PR auto reviews can be disabled here). Sorry for that again.

Anyway, seems like Psalm 6.x doesn't support PHP 8.6 (yet?). I can create a PR for 8.6 tests once that's GA, and we'll see if Psalm 6 will support it or whether Psalm 7 would need to be introduced. Can help with both then.

@spaze
spaze deleted the spaze/php-8.6-tests branch November 6, 2026 21:22
@paragonie-security

Copy link
Copy Markdown
Contributor

Thanks, please feel free if we don't get to it first once the upstream blockers are resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants