Repository navigation
[rejected AI] Preserve explicitly empty choice labels - #937
Closed
xianjianlf2 wants to merge 1 commit into
Closed
xianjianlf2 wants to merge 1 commit into
xianjianlf2 wants to merge 1 commit into
Conversation
Member
davidism
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicitly empty choice labels are currently replaced with the choice value when rendering selects or radio buttons. For example,
SelectField(choices=[('blank', '')])renders an option displayingblankon main, whereas WTForms 3.2.1 renders an empty label.Use the value fallback only when the label is
None, preserving empty strings in option subfields, the Select widget, and the pre-3.3render_optioncompatibility adapter. Omitted labels still default to the choice value.Add regressions for select, multiple-select, and radio fields with grouped and ungrouped choices, plus a legacy custom renderer. All 7 new cases fail before the fix. Afterward, all 533 tests and all
prek run --all-fileschecks pass. The original behavior was also verified against an isolated WTForms 3.2.1 installation.AI-assisted implementation and validation.