Skip to content

fix: null-guard enum choices in GameRulesetSchemaEntry (list-game-ruleset-schemas crash) #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sandsand244263 wants to merge 4 commits into from
Closed

fix: null-guard enum choices in GameRulesetSchemaEntry (list-game-ruleset-schemas crash) #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
faaffd8
change ci zip filename to match previous builds
ZingBallyhoo Oct 11, 2026
7180bae
O is not a hex digit
ZingBallyhoo Oct 11, 2026
546efa1
news to me that flags are case sensitive, so lets fix the region flags
ZingBallyhoo Oct 11, 2026
126f628
fix: null-guard enum choices in GameRulesetSchemaEntry
sandsand244263 Oct 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/dotnet.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
- name: Upload Release
uses: actions/upload-artifact@v4
with:
name: toolchain-release-windows
name: toolchain-release
path: dist/Release/win
- name: Upload Release
uses: actions/upload-artifact@v4
Expand Down
9 changes: 5 additions & 4 deletions DataTool/DataModels/GameModes/GameRulesetSchemaEntry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
using System.Linq;
using System;
using System.Linq;
using TankLib;
using TankLib.STU.Types;
using TankLib.STU.Types.Enums;
Expand Down Expand Up @@ -36,11 +37,11 @@ public GameRulesetSchemaEntry(STUGameRulesetSchemaEntry entry) {
break;
case STU_776E5ADD val2:
Value = new RulesetSchemaValueEnum {
DefaultValue = val2.m_default.ToString(),
Choices = val2.m_3FE1EA9E.Select(x => new RulesetSchemaValueEnumChoice {
DefaultValue = val2.m_default?.ToString(),
Choices = val2.m_3FE1EA9E?.Select(x => new RulesetSchemaValueEnumChoice {
DisplayText = GetString(x.m_displayText),
Identifier = x.m_identifier
}).ToArray()
}).ToArray() ?? Array.Empty<RulesetSchemaValueEnumChoice>()
};
break;
case STU_A499C365 val3:
Expand Down
2 changes: 1 addition & 1 deletion DataTool/Static/GUIDNames.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -712,7 +712,7 @@ FFB,078,Voicelines,1 ; 1.62
1AED,078,Voicelines,1 ; 2026 - s5 - solo leveling
1AEE,078,Voicelines,1 ; 2026 - s5 - solo leveling
1AEF,078,Voicelines,1 ; 2026 - s5 - solo leveling
1AFO,078,Voicelines,1 ; 2026 - s5 - solo leveling
1AF0,078,Voicelines,1 ; 2026 - s5 - solo leveling
; Note: Weapon models are often two entities, one for 1P, one for 3P, if they have different animations
; Ana,Classic,47,
1610,003,Teabag,0
Expand Down
2 changes: 2 additions & 0 deletions DataTool/ToolFlags.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,11 @@ public class ToolFlags : IToolFlags {
public bool StringsAsGuids;

[CLIFlag(Default = false, Flag = "rcn", Help = "Load Chinese exclusive content", Parser = new[] {"DataTool.Flag.Converter", "CLIFlagBoolean"})]
[Alias("RCN")]
public bool RCN;

[CLIFlag(Default = false, Flag = "rkr", Help = "Load Korean exclusive content", Parser = new[] {"DataTool.Flag.Converter", "CLIFlagBoolean"})]
[Alias("RKR")]
public bool RKR;

[CLIFlag(Default = null, Flag = "scratchdb", Hidden = true, NeedsValue = true, Help = "Directory for persistent database storage for deduplication info")]
Expand Down