You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Mixed dense JANGH bundles name down-projection banks model.layers.N.mlp.down_proj.tq2_*. The named mmap API rejected these names even when their packed data and scales already satisfied the bank contract, preventing the actual model from loading. Admit this specific namespace only for a one-expert leading dimension, retaining rank, dtype, byte-size, layer bounds, registration and ownership checks. Routed-bank admission is unchanged.
Validation on local M5 Max2: the rebuilt native C++ library passed a Swift C-API regression covering packed/scales ownership, layer advice, release, and malformed-name/shape rejection. The real Diplodocus mixed bundle then loaded and completed eight native BatchEngine generations including two tool/result continuations and a fresh SSD-coordinator replay. Added equivalent C++ regression coverage; that C++ test runner has not been executed separately.
This change makes no claim about whole-model Python/Swift numerical parity, speed parity, or low resident footprint; those remain separate runtime qualifications.
SOURCE EVIDENCE: head 93682f62865df3a4077835fb3a8bbb022715770b, mlx/io/safetensors.cpp: the production file SHA256 2850ac10cc17662b981b6ba57be0b73fe4965c10d1dbfb14d9064ed3fe36bf0f matches the source captured before the local qualification build. Dense admission is restricted to canonical down banks with leading dimension 1; existing routed validation remains intact.
LIVE EVIDENCE: local Max2 Release build plus the C-API regression JANGHDenseNamedMmapTests.testDenseNamesRetainMappedOwnershipAndRejectInvalidBanks passed. It checks both packed and scale mappings, exact tracked-byte accounting, layer/expert advice, owner release, invalid namespaces, malformed layer IDs, wrong leading dimension/dtype/size. The real mixed bundle also loaded and completed eight native BatchEngine generations with natural stops, 38.8–41.3 tok/s, and a fresh-coordinator SSD restore matching 1,038 tokens; paged RAM stayed off. Local receipts: diplodocus-flash-runtime-20261005/qualification/test3.log, behavior-001-receipt.json, and per-turn JSON.
The equivalent newly added C++ test-runner case has not been executed separately. Whole-model numerical parity and Osaurus consumption are tracked separately; this merge claims only the bounded named-map loader correction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mixed dense JANGH bundles name down-projection banks
model.layers.N.mlp.down_proj.tq2_*. The named mmap API rejected these names even when their packed data and scales already satisfied the bank contract, preventing the actual model from loading. Admit this specific namespace only for a one-expert leading dimension, retaining rank, dtype, byte-size, layer bounds, registration and ownership checks. Routed-bank admission is unchanged.Validation on local M5 Max2: the rebuilt native C++ library passed a Swift C-API regression covering packed/scales ownership, layer advice, release, and malformed-name/shape rejection. The real Diplodocus mixed bundle then loaded and completed eight native BatchEngine generations including two tool/result continuations and a fresh SSD-coordinator replay. Added equivalent C++ regression coverage; that C++ test runner has not been executed separately.
This change makes no claim about whole-model Python/Swift numerical parity, speed parity, or low resident footprint; those remain separate runtime qualifications.