Repository navigation
Conversation
dbt 2.x (Fusion) writes a unit test's checksum as {"name": ..., "checksum": ...}
where dbt Core writes a plain string, so parse_manifest rejected every dbt 2.x
manifest containing a unit test. Accept either form on UnitTests.checksum and
cover it with a dbt 2.0.9 manifest that has a unit test. Bump to 0.1.6.
Refs open-metadata/OpenMetadata#37570
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
dbt 2.x (Fusion) writes a unit test's
checksumas an object, while the v12 model expects a string, soparse_manifest()fails on any dbt 2.x manifest that contains a unit test:Follow-up to #7; refs open-metadata/OpenMetadata#37570. OpenMetadata dbt ingestion is not affected (it blanks
unit_testsbefore parsing); direct callers of the parser are.Change
UnitTests.checksum:Optional[str]→Optional[Union[str, Checksum]]inmanifest_v12,manifest_cloud,manifest_cloud_v1,manifest_cloud_v2, reusing the existingChecksummodel that nodes use. dbt Core's string form still parses asstr.tests/resources/v12/jaffle_shop/manifest_2.0_unit_tests.json, generated bydbt==2.0.9(models, seeds, snapshot, sources, tests, unit test, exposure, semantic model + metric), added toTestManifestParser.Testing
mainwith the error above and pass with the fix; full suitepytest tests→ 76 passed;pre-commit run --all-filesclean.str.🤖 Generated with Claude Code