Skip to content

Skip the Neovim clipboard repair when omarchy-nvim is not installed - #17171

Open
stevederico wants to merge 2 commits into
omacom:quattrofrom
stevederico:fix/nvim-clipboard-migration-without-package
Open

stevederico wants to merge 2 commits into
omacom:quattrofrom
stevederico:fix/nvim-clipboard-migration-without-package

Conversation

@stevederico

@stevederico stevederico commented Oct 31, 2026 •

Copy link
Copy Markdown

Fixes #16180.

Migration 1788996284 treated a missing omarchy-nvim package as a failure. pacman -Q exits 1, and omarchy-migrate runs each migration under bash -euo pipefail, so the queue stopped and every later migration stayed pending.

When the package is gone there is no corrected provider to install. The migration now leaves the existing config alone and exits 0. An installed package that is older than 2026.9.21-2 still stays pending, as before.

Testing

No suite test, per agents/skills/migrations.md. Checked by hand against scratch homes with the June provider:

  • omarchy-nvim missing: exits 0, says it skipped, file unchanged
  • omarchy-nvim 2026.9.21-5 installed: replaced with the packaged provider, backup kept
  • Customized provider, or no provider: exits 0, file unchanged
  • quattro's version with the package missing: exits 1

@greptile-apps

greptile-apps Bot commented Oct 31, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

The migration now leaves the Neovim config alone and succeeds when omarchy-nvim is missing.

  • Neovim migrations skip the clipboard repair when their package is missing.

Reviews (2) · Last reviewed commit: "Drop the Neovim clipboard migration test" · Reviewed by Greptile

Migration 1788996284 ran pacman -Q under errexit. A home that still has the
stock remote_clipboard.lua but no longer has omarchy-nvim aborted the
migration queue, so every later migration stayed pending.
@stevederico
stevederico force-pushed the fix/nvim-clipboard-migration-without-package branch from e3a5daa to 790643f Compare November 2, 2026 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Migration 1788996284 aborts the migration queue when a stock remote_clipboard.lua exists but omarchy-nvim is not installed

1 participant