Skip to content

fetchers: Fix gist fetcher - #210

Merged
RytoEX merged 2 commits into
obsproject:masterfrom
RytoEX:fix-gist-fetcher
Oct 19, 2026
Merged

RytoEX merged 2 commits into
obsproject:masterfrom
RytoEX:fix-gist-fetcher

Conversation

@RytoEX

@RytoEX RytoEX commented Oct 17, 2026

Copy link
Copy Markdown
Member

Description

This PR contains two commits:

  • fetchers: Update gist fetcher to check for usernames
  • fetchers: Expand empty description check to include null

Motivation and Context

The first commit fixes checking gist URLs if they contain a username: https://gist.github.com/<username>/<gistId>. GitHub usernames can only contain alphanumeric characters and hyphens, and must be 1-39 characters.

The second commit fixes parsing gist JSON if the description is null instead of "". I don't know what causes this to happen, but I've been shown a gist that does this.

How Has This Been Tested?

Did some quick tests locally.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)

Checklist:

  • I have read the contributing document.
  • My code has been run through clang-format.
  • My code follows the project's style guidelines
  • My code is not on the master branch.
  • My code has been tested.
  • All commit messages are properly formatted and commits squashed where appropriate.
  • I have included updates to all appropriate documentation.

@RytoEX
RytoEX requested review from notr1ch and prgmitchell October 17, 2026 19:34

@prgmitchell prgmitchell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@RytoEX
RytoEX merged commit de967b0 into obsproject:master Oct 19, 2026
2 checks passed
@RytoEX
RytoEX deleted the fix-gist-fetcher branch October 19, 2026 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants