Repository navigation
fetchers: Fix gist fetcher - #210
Merged
Merged
Conversation
7 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR contains two commits:
Motivation and Context
The first commit fixes checking gist URLs if they contain a username:
https://gist.github.com/<username>/<gistId>. GitHub usernames can only contain alphanumeric characters and hyphens, and must be 1-39 characters.The second commit fixes parsing gist JSON if the description is
nullinstead of"". I don't know what causes this to happen, but I've been shown a gist that does this.How Has This Been Tested?
Did some quick tests locally.
Types of changes
Checklist: