Repository navigation
feat: configurable PodDisruptionBudget per component - #127
Merged
Merged
Conversation
Add an optional podDisruptionBudget field with minAvailable and maxUnavailable to spec.bindplane, spec.opamp, spec.nats and spec.transformAgent. A CEL rule and the shared validation package reject specs that set both. When the field is unset the operator keeps the current minAvailable: 1 budget, and disablePodDisruptionBudget still removes the PDB.
joe-armstrong
marked this pull request as ready for review
September 24, 2026 15:35
jsirianni
requested changes
Sep 24, 2026
Replace the custom PodDisruptionBudgetSpec with the upstream k8s.io/api/policy/v1 type. The operator still sets the selector, and a CEL rule rejects specs that set it. unhealthyPodEvictionPolicy is now passed through to the managed PDB.
This reverts commit a42fbab.
jsirianni
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every operator-managed PDB uses a hard-coded
minAvailable: 1. With 20 OpAMP pods that allows 19 to be evicted at once during a node drain or autoscaler scale-down, and with 3 NATS pods it allows 2. This makes the budget configurable per component.What changed
podDisruptionBudgetfield tospec.bindplane,spec.opamp,spec.natsandspec.transformAgent. It uses the upstream policy/v1 PodDisruptionBudgetSpec.selectoror bothminAvailableandmaxUnavailable.unhealthyPodEvictionPolicyis passed through.minAvailable: 1.disablePodDisruptionBudget: truestill removes the PDB.Testing
maxUnavailable,minAvailable, switching between the two on an existing PDB, disabled,unhealthyPodEvictionPolicypassthrough, and CEL rejection of both fields and ofselector. Also added validation unit tests.make test,make lintandmake gosecpass.