Repository navigation
fix: use singular wording in the addIterations() bounds warning - #50
Merged
Merged
Conversation
With one row outside the new bounds it read "1 parameter sets ... are". Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The warning
addIterations()gives when new bounds exclude earlier results always used the plural, so with one excluded row it read "1 parameter sets in scoreSummary are outside the new bounds". It now pluralises withcli::format_inline().This is meant to ship as 1.4.1, which goes to CRAN in place of 1.4.0.
Related GitHub Issues and PRs
Are these changes tested?
Yes. A new test checks the wording with one and with two excluded rows. The full suite passes locally, and
air formatandjarl checkare clean.Are there any user-facing changes?
Yes, the warning text is grammatical for a single excluded row.
Was AI used for this PR?
In accordance with the AI generation guidelines, please disclose whether and how AI was used in this PR.
PR code and description written by:
Reviewed before submission by:
Checklist
fix:,feat:,docs:, ...); it becomes theNEWS.mdentry.air format .andjarl check ..devtools::document()if documentation changed.testthatunit tests totests/testthatfor any new functionality or fixed bug.Assisted-by: Claude Code