Skip to content

fix: use singular wording in the addIterations() bounds warning - #50

Merged
novica merged 1 commit into
mainfrom
fix-bounds-warning-plural
Oct 11, 2026
Merged

novica merged 1 commit into
mainfrom
fix-bounds-warning-plural

Conversation

@novica

@novica novica commented Oct 4, 2026

Copy link
Copy Markdown
Owner

Summary

The warning addIterations() gives when new bounds exclude earlier results always used the plural, so with one excluded row it read "1 parameter sets in scoreSummary are outside the new bounds". It now pluralises with cli::format_inline().

This is meant to ship as 1.4.1, which goes to CRAN in place of 1.4.0.

Related GitHub Issues and PRs

Are these changes tested?

Yes. A new test checks the wording with one and with two excluded rows. The full suite passes locally, and air format and jarl check are clean.

Are there any user-facing changes?

Yes, the warning text is grammatical for a single excluded row.

Was AI used for this PR?

In accordance with the AI generation guidelines, please disclose whether and how AI was used in this PR.

PR code and description written by:

  • Human
  • AI

Reviewed before submission by:

  • Human
  • AI
  • Not reviewed

Checklist

  • I understand and agree to the Code of Conduct.
  • The PR title follows Conventional Commits (fix:, feat:, docs:, ...); it becomes the NEWS.md entry.
  • I have run air format . and jarl check ..
  • I have updated roxygen comments and run devtools::document() if documentation changed.
  • I have added testthat unit tests to tests/testthat for any new functionality or fixed bug.

Assisted-by: Claude Code

With one row outside the new bounds it read "1 parameter sets ... are".

Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
@novica
novica merged commit 382d7f2 into main Oct 11, 2026
7 checks passed
@novica
novica deleted the fix-bounds-warning-plural branch October 11, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant