Repository navigation
Fixes #15: Fix missing notifications for Jobs cancelled during cutover - #93
Merged
jnovinger merged 1 commit intoOct 30, 2026
Merged
Conversation
Cutover now fails a waiting Job and writes its owner's notice in one transaction, so an interrupted pass leaves neither and the resumed pass sends it. A retried Job's earlier notice is re-issued. Fixes #15
pheus
marked this pull request as ready for review
October 30, 2026 15:46
jnovinger
approved these changes
Oct 30, 2026
jnovinger
deleted the
15-an-interrupted-cutover-can-omit-a-cancelled-runs
branch
October 30, 2026 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #15
Cutover now saves a cancelled Job's failed state and owner notification in a single transaction, so an interrupted pass can safely resume without losing the notification. If a retried Job already has a notification, it is refreshed and marked unread rather than duplicated.