Skip to content

Flesh out CMake support - #37

Merged
justinmk merged 13 commits into
neovim:masterfrom
jamessan:cmake-fixes
Aug 27, 2026
Merged

justinmk merged 13 commits into
neovim:masterfrom
jamessan:cmake-fixes

Conversation

@jamessan

Copy link
Copy Markdown
Member

This should cover all the existing support from the autoconf/Make build:

  • building tools/
  • building and running tests
  • generating and install the man pages
  • installing the library / header files
  • regenerating the static test files based on existing terminfo files

@justinmk
justinmk merged commit 7e43ffb into neovim:master Aug 27, 2026
2 checks passed
@clason

clason commented Aug 27, 2026

Copy link
Copy Markdown
Member

I'll re-run Neovim CI on these changes and make a new release if they pass.

EDIT: They don't, because the Zig build scripts also need updating. Not an issue with this repo, but this raises the question whether we want to upstream the (fixed) Zig scripts?

@jamessan

jamessan commented Aug 27, 2026 •

Copy link
Copy Markdown
Member Author

make a new release if they pass.

Note, the last release should have bumped LT_REVISION to 2. Now that the shared-library version information is correctly being set in CMakeLists.txt, that should also be updated.

There should also be an annotated tag for the release. v2.1.3 was just a lightweight tag.

@jamessan
jamessan deleted the cmake-fixes branch August 27, 2026 10:48
@clason

clason commented Aug 27, 2026 •

Copy link
Copy Markdown
Member

I don't think annotated or not makes a difference to releases? (At least, all other projects I maintain work fine with lightweight tags.)

EDIT: I may not have pushed any tag at all (yet) because I wanted to run downstream CI first.

In any case, it sounds like it's better if you handle the release, so please go ahead!

@clason

clason commented Aug 28, 2026

Copy link
Copy Markdown
Member

@jamessan This change negatively impacts Neovim build time (slightly). Can regenerating ALL THE FILES, docs, and tools be made optional so Neovim build can (again) only build the library proper?

(And, yes, I didn't push a tag at all because v2.1.3 turned out to be broken and should not be picked up by any downstream.)

social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
unibilium 2.1.4

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
* Change terminfo search logic closer to ncurses by @f380cedric in neovim/unibilium#31
* Add minimal GH CI by @jamessan in neovim/unibilium#34
* Support terminfo files larger than 4K by @jamessan in neovim/unibilium#33
* release v2.1.3 by @clason in neovim/unibilium#35
* Flesh out CMake support by @jamessan in neovim/unibilium#37
* feat(build): add initial build.zig by @clason in neovim/unibilium#38
* cmake: Add options to control building of docs, tools, and tests by @jamessan in neovim/unibilium#41
* release v2.1.4 by @clason in neovim/unibilium#40

## New Contributors
* @f380cedric made their first contribution in neovim/unibilium#31
* @jamessan made their first contribution in neovim/unibilium#34
* @clason made their first contribution in neovim/unibilium#35

**Full Changelog**: https://github.com/neovim/unibilium/compare/v2.1.2...v2.1.4</pre>
  <p>View the full release notes at <a href="https://github.com/neovim/unibilium/releases/tag/v2.1.4">https://github.com/neovim/unibilium/releases/tag/v2.1.4</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!18139
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants