Repository navigation
fix(oxlint): support Vite+ via vp lint - #4549
Conversation
4418300 to
86ea5b4
Compare
This all sounds like gibberish to me. Is oxlint a separate project or is If oxlint is a separate project, and "vite" was shipping |
|
oxlint is the actual linter. vite+ embeds oxlint and some other tools to provide complete js/ts ecosystem tooling. when using vite+ you don't need to seperatly install oxlint as it is already embeded and exposed as the |
|
glancing at https://github.com/voidzero-dev/vite-plus , it looks like "vite plus" some sort of distro for "vite", and has nothing to do with vite itself. This PR starts by casually mentioning "Vite+" as if that is just an obvious thing. Without explaining that Vite+ is a third-party wrapper around Vite. So "vite plus" is doing random things and now expects the entire ecosystem (such as these lsp configs) to bend over for it? |
|
both oxlint and vite plus is developed by the same team. they just provide the option to use the linter however you see fit or as a part of a more complete toolset being vite+. |
|
I see... well, good luck out there. |
Vite+ exposes
vpbut no longer provides a standaloneoxlintbinary. The oxlint config already recognizes Vite+ projects, but it only looks foroxlint, so the language server fails to start when a project uses Vite+ without a separate oxlint installation.Look for
oxlintandvpin the project'snode_modules/.binbefore checkingPATH. Keepoxlintpreferred within each location, and startvpwithlint --lspwhen selected.Related discussion: voidzero-dev/vite-plus#3016. That PR proposed restoring the editor binaries; the discussion explains that the wrappers were removed because they could conflict with the upstream packages during installation.
Validation: 48 executable-discovery cases in headless Neovim using temporary executable files, StyLua, LuaLS diagnostics, and the repository lint script all pass.