Repository navigation
Add type annotations for emmylua_ls - #4534
Merged
Merged
Conversation
6 tasks
justinmk
reviewed
Sep 25, 2026
justinmk
reviewed
Sep 25, 2026
justinmk
reviewed
Sep 25, 2026
Member
|
Thank you, I was missing this 👍 |
oriori1703
force-pushed
the
feature/emmylua-ls-schema
branch
3 times, most recently
from
October 5, 2026 00:11
97aa73b to
62f8a3a
Compare
Contributor
Author
|
I added more clarification comments, refactored the code a bit to make it more readable, and added better error handling . Also I added support for more reference kinds (like arrays and percent encoding). BTW, as a bonus it seems those changes improve other annotations too as you can see in 6699548 :) |
Contributor
Author
|
Let me know I you want me to change anything else. |
oriori1703
force-pushed
the
feature/emmylua-ls-schema
branch
from
October 5, 2026 00:28
62f8a3a to
ff74b71
Compare
Member
|
Thanks. An AI review found issues, I'll do a followup to fix them. #4544 |
Contributor
Author
|
Thanks :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I also updated the generator to be able to parse emmylua's json schema. this includes:
$ref$schemainside of the schema