Skip to content

Add type annotations for emmylua_ls - #4534

Merged
justinmk merged 8 commits into
neovim:masterfrom
oriori1703:feature/emmylua-ls-schema
Oct 5, 2026
Merged

justinmk merged 8 commits into
neovim:masterfrom
oriori1703:feature/emmylua-ls-schema

Conversation

@oriori1703

Copy link
Copy Markdown
Contributor

I also updated the generator to be able to parse emmylua's json schema. this includes:

  • support for $ref
  • ignoring $schema inside of the schema

Comment thread scripts/gen_json_schemas.lua Outdated
Comment thread scripts/gen_json_schemas.lua Outdated
Comment thread scripts/gen_annotations.lua
@justinmk

Copy link
Copy Markdown
Member

Thank you, I was missing this 👍

@oriori1703
oriori1703 force-pushed the feature/emmylua-ls-schema branch 3 times, most recently from 97aa73b to 62f8a3a Compare October 5, 2026 00:11
@oriori1703

oriori1703 commented Oct 5, 2026 •

Copy link
Copy Markdown
Contributor Author

I added more clarification comments, refactored the code a bit to make it more readable, and added better error handling .

Also I added support for more reference kinds (like arrays and percent encoding).

BTW, as a bonus it seems those changes improve other annotations too as you can see in 6699548 :)

@oriori1703

Copy link
Copy Markdown
Contributor Author

Let me know I you want me to change anything else.
Once you think this is ready I can clean up the commit a bit (unless you prefer to just squash everything)

@oriori1703
oriori1703 force-pushed the feature/emmylua-ls-schema branch from 62f8a3a to ff74b71 Compare October 5, 2026 00:28
@justinmk

justinmk commented Oct 5, 2026 •

Copy link
Copy Markdown
Member

Thanks. An AI review found issues, I'll do a followup to fix them. #4544

@justinmk
justinmk merged commit 0f9e596 into neovim:master Oct 5, 2026
5 checks passed
@oriori1703
oriori1703 deleted the feature/emmylua-ls-schema branch October 5, 2026 21:49
@oriori1703

Copy link
Copy Markdown
Contributor Author

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants