Repository navigation
Conversation
…d_shell The TLS Credentials Shell of Zephyr can now generate the device private key and the CSR on the device (cred keygen and cred csr). Use it for the tls_cred_shell command type when no local certificate is given, instead of failing. The private key never leaves the device, and with --verify the device public key is compared with the device certificate, like for nrf_cloud_cred_shell. With --local-cert or --local-cert-file, the command type still installs a key generated on the host. The TLS Credentials Shell prints the public key as a DER SubjectPublicKeyInfo, and the nrf_cloud_cred shell prints a raw SEC1 point, so compare the format that the device returns. This needs nrfcredstore with TLSCredKeygenShellInterface. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
Newer firmware generates the key and the CSR with the TLS Credentials Shell, which the tls_cred_shell command type supports, and does not have the nrf_cloud_cred shell commands. Keep nrf_cloud_cred_shell working for older firmware, but print a warning when it is used and mark it as deprecated in the help text. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The TLS Credentials Shell of Zephyr can now generate the device private key and the CSR on the device (cred keygen and cred csr). Use it for the tls_cred_shell command type when no local certificate is given, instead of failing. The private key never leaves the device, and with --verify the device public key is compared with the device certificate, like for nrf_cloud_cred_shell. With --local-cert or --local-cert-file, the command type still installs a key generated on the host.
The TLS Credentials Shell prints the public key as a DER SubjectPublicKeyInfo, and the nrf_cloud_cred shell prints a raw SEC1 point, so compare the format that the device returns.
This needs nrfcredstore with TLSCredKeygenShellInterface.