[tiny-ac]

Description

Configuration.md and Architecture.md say client-side mode is disabled when the SCCACHE_ERROR_LOG environment variable is set, but the code actually checks the SCCACHE_LOG env variable.

SCCACHE_ERROR_LOG is read when the daemon starts to redirect stderr and it's also mentioned in the code comment where the client-side check runs, but the code actually reads LOGGING_ENV, a constant that holds the environment variable name (SCCACHE_LOG).

Ran a compile with a fresh cache and a freshly started server:

• With SCCACHE_CLIENT_SIDE=1, setting only SCCACHE_ERROR_LOG keeps client-side mode
  • sccache --show-stats shows Compile requests 0
• SCCACHE_LOG=warn switches back to server-side mode
  • sccache --show-stats shows Compile requests 1

Changes

This PR changes both docs to name SCCACHE_LOG instead of SCCACHE_ERROR_LOG.

[sylvestre]

maybe make the reason match the new variable? something like:

Suggested change

	- **logging** (`SCCACHE_LOG`): the client always logs to stderr, and
	- **logging** (`SCCACHE_LOG`): the client always logs to stderr, ignoring
	`SCCACHE_ERROR_LOG`, and multiple concurrent CLI processes would race on the log file, and

[tiny-ac]

@sylvestre Thanks! Applied with a small rewording to avoid the double "and"

[codecov-commenter]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.54%. Comparing base (dac6c80) to head (fb2fed6).

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2969      +/-   ##
==========================================
- Coverage   78.54%   78.54%   -0.01%     
==========================================
  Files          74       74              
  Lines       44039    44039              
==========================================
- Hits        34591    34590       -1     
- Misses       9448     9449       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[sylvestre]

Thanks for your PR