Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2967 +/- ##
==========================================
+ Coverage 78.54% 78.69% +0.14%
==========================================
Files 74 74
Lines 44039 44154 +115
==========================================
+ Hits 34591 34745 +154
+ Misses 9448 9409 -39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sylvestre
reviewed
Oct 30, 2026
| compilation increments `Cache read errors` as well as the existing `Cache errors` | ||
| and `Cache misses` counters. Ordinary misses do not increment the read-error | ||
| counter, and overall lookup timeouts are recorded separately as `Cache timeouts`. | ||
| Errors handled inside a multilevel tier walk are not aggregate lookup errors. |
Collaborator
There was a problem hiding this comment.
i didn't understand this line, could you please clarify or drop it? :)
sylvestre
reviewed
Oct 30, 2026
| Ok(entry) => Ok(Cache::Hit(entry)), | ||
| Err(_) => Ok(Cache::Miss), | ||
| } | ||
| Ok(Cache::Hit(CacheRead::from(file)?)) |
Collaborator
There was a problem hiding this comment.
maybe add a with_context with the path like the open above? otherwise the read error log doesn't say which entry is broken
sylvestre
reviewed
Oct 30, 2026
| } | ||
| async fn get_raw(&self, _key: &str) -> Result<Option<Bytes>> { | ||
| let next = self.raw_rx.lock().await.try_next().unwrap(); | ||
| next.unwrap_or(Ok(None)) |
Collaborator
There was a problem hiding this comment.
try_next() returns Err when nothing is queued (tx is still alive), so the unwrap above panics and this unwrap_or never applies, no?
maybe just expect(...) like get does
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing two gaps in read-error metrics:
cache_errorsand omittedcache_read_errorsIpcStoragealso treated invalid cached archives as misses.BREAKING CHANGE: the storage RPC response format changes, so the client and daemon need matching rebuilt binaries; restart the daemon after upgrading.