Repository navigation
Conversation
rustc lists the profile in its dep-info, so its contents already reach the hash key. Listing it as an output made every cache hit write it back, and the new mtime made cargo rebuild every crate that reads it. Fixes mozilla#2960
feder-cr
force-pushed
the
rust-profile-use-is-an-input
branch
from
October 28, 2026 06:48
260aee4 to
f8ba006
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2961 +/- ##
==========================================
- Coverage 78.54% 78.54% -0.01%
==========================================
Files 74 74
Lines 44039 44082 +43
==========================================
+ Hits 34591 34624 +33
- Misses 9448 9458 +10 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
The match's fallback arm only runs when parsing fails, so it was a line of the patch no test could cover. The arguments need no working directory (no response file, no -L path), which is what parses! assumes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2960.
#2306 added the file of
-C profile-useto a Rust compilation's outputs, so every cache hit rewrote the profile and gave it a new mtime, and cargo then rebuilt every crate that reads it. The profile is an input: it is in rustc's dep-info, so its contents already reach the hash key and the dist inputs. This removes it from the outputs.The new test checks that the profile is not an output and that changing its contents still changes the key. It fails on main with
merged.profdataamong the outputs.Ran
cargo fmt -- --check, the clippy command from AGENTS.md on 1.91.0, andcargo test --locked --lib --bins --testslocally; the CI on my fork passes apart from the Codecov and CodSpeed uploads, which need tokens the fork does not have.