Skip to content

bug fix in volume constraint buffer value passed to Constraint plugin. #1383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chrisjonesBSU merged 2 commits into from
Nov 8, 2026
Merged

bug fix in volume constraint buffer value passed to Constraint plugin. #1383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
12b6073
Use particle size for the volume constraint buffer value in the main …
Nov 3, 2026
28559df
Update macos version in CI os matrix
Nov 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/CI.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [macOS-latest, macOS-14, ubuntu-latest]
os: [macOS-latest, macOS-15, ubuntu-latest]
python-version: ["3.14"]

defaults:
Expand Down
2 changes: 1 addition & 1 deletion mbuild/path/build.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1470,7 +1470,7 @@ def hard_sphere_random_walk(
)
if state.volume_constraint:
is_inside_mask = volume_constraint.is_inside(
points=candidates, buffer=tolerance
points=candidates, buffer=radius
)
candidates = candidates[is_inside_mask]
# If there is a bias, sort candidates according to the bias
Expand Down
Loading