Repository navigation
Fix Chroma HNSW crash after \\reset - #104
Merged
Merged
Conversation
\\reset deletes the branch user/AI collections. The next turn retrieves before it stores, so Chroma get-or-creates an empty HNSW segment and similarity_search raises: Error creating hnsw segment reader: Nothing found on disk Skip the search when count is 0 (store_data fills the index later this turn). If HNSW is already corrupt, drop the collection instead of crashing the plan.
Assistant retrieve always used the shared assistant_* collections, while
store/clone/reset used {branch}_*. After \\branch then \\reset, hello
still pulled the parent's RAG.
User/AI collections now follow the branch name. Gold stays shared
(assistant_gold_documents). \\reset / delete-branch call wipe_branch_stores
so they destroy those two collections and their parent docstores, and
never glob {branch}* (that would delete gold when resetting assistant).
Adds a workflow that installs Python deps (minus the conda-only
nodejs line) and runs test_harness.py on push to main and every PR.
Also documents that wipe_branch_stores('branch_x') leaves branch_y
and gold alone.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
\\resetwipes the branch user/AI collections. The next turn retrieves before it stores, so Chroma get-or-creates an empty HNSW segment andsimilarity_searchraises:That is especially easy to hit after branching (clone creates the named collections) then resetting them.
Fix (
rag_manager.py):store_datafills the index later this turn.delete_collectionno longer opens-to-delete via a query path.After merge:
\\resetthenhello!should just chat.