Repository navigation
feat(react-menu): add opt-in autofocus suppression #36864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Paul Mardling (PaulGMardling)
wants to merge
13
commits into
microsoft:master
Choose a base branch
from
PaulGMardling:paulgmardling-menu-composition-apis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+709
−21
Open
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
96ceccf
feat(react-menu): support external triggers and autofocus suppression
PaulGMardling 5859186
Merge branch 'master' into paulgmardling-menu-composition-apis
PaulGMardling be05e7d
fix(react-menu): preserve focus for equivalent autofocus defaults
PaulGMardling 41885a6
Merge remote Menu proposal updates
PaulGMardling 930929c
fix(react-menu): harden editable command composition
PaulGMardling d05824c
fix(react-menu): keep command status clear of the popup
PaulGMardling ca468b7
Merge branch 'master' into paulgmardling-menu-composition-apis
PaulGMardling 8d11bc6
fix(react-menu): scope WXP support to autofocus suppression
PaulGMardling 074ced7
test(react-headless-components-preview): avoid error suppression
PaulGMardling 150e492
test(react-headless-components-preview): remove synthetic type test
PaulGMardling 7ba9ccf
feat(react-headless-components-preview): support Menu autofocus suppr…
PaulGMardling 88f0b2a
fix(react-headless-components-preview): close Menu before native Tab …
PaulGMardling a033357
Merge branch 'master' into paulgmardling-menu-composition-apis
PaulGMardling File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-headless-components-preview-1d127060-0216-4392-bc0a-a24e871a1445.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "patch", | ||
| "comment": "fix(react-headless-components-preview): exclude unsupported styled Menu composition props", | ||
| "packageName": "@fluentui/react-headless-components-preview", | ||
| "email": "paulmardling@microsoft.com" | ||
| } |
6 changes: 6 additions & 0 deletions
6
change/@fluentui-react-menu-30d61893-5bcf-4c48-81a4-eead2c836beb.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| { | ||
| "type": "minor", | ||
| "comment": "feat(react-menu): add opt-in autofocus suppression and external trigger registration", | ||
| "packageName": "@fluentui/react-menu", | ||
| "email": "paulmardling@microsoft.com" | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ct-components/react-headless-components-preview/library/src/components/Menu/Menu.types.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.