Repository navigation
docs: use explicit UTF-8 encoding in redirect generation script - #8376
Open
TINGyu123644 wants to merge 1 commit into
Open
TINGyu123644 wants to merge 1 commit into
TINGyu123644 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
python/docs/redirects/redirects.pyreads the redirect template, writes the generated redirectindex.htmlpages, and reads the redirect URL list without specifying an explicit encoding. On Windows locales where Python's default encoding is not UTF-8, this can raiseUnicodeDecodeError/UnicodeEncodeErrorwhen those files contain non-ASCII characters. Fixes #7749.This is an AI-assisted documentation-tooling fix.
Related issue number
Fixes #7749
Checks
encoding="utf-8"to threeopen()calls.python -m py_compilethat the edited script still compiles.Behavior is unchanged for ASCII content and is now safe for non-ASCII files on systems whose default encoding is not UTF-8.