Repository navigation
fix(file-surfer): reset search state when opening another path - #8372
Open
BUG设计工程师 (hackermengzhi) wants to merge 1 commit into
Open
BUG设计工程师 (hackermengzhi) wants to merge 1 commit into
BUG设计工程师 (hackermengzhi) wants to merge 1 commit into
Conversation
Author
@microsoft-github-policy-service agree |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Opening a new path leaves FileSurfer's previous search active. After searching file A, opening file B and searching for the same term can skip file B's first viewport;
find_next()also reuses a query that was never started on file B.set_path()assigns two unused public attributes instead of clearing the private search fields read byfind_on_page()andfind_next(). Reset those fields on navigation. Add public-behavior regressions for clearing an old query and searching the first viewport of a new file, plus a control for cycling matches within one file.Validation on Python 3.12.13:
Related issue number
No existing issue found for search-state reset on navigation.
Checks