Repository navigation
fix(examples): keep completion tokenizer in sync with model overrides - #670
Open
Tianyuan Ding (likecake) wants to merge 2 commits into
Open
Tianyuan Ding (likecake) wants to merge 2 commits into
Tianyuan Ding (likecake) wants to merge 2 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
Contributor
|
We do not need tests for examples. Please remove the tests and I will merge this PR. |
|
unsubscribe
…On Mon, Nov 2, 2026 at 9:28 AM Zhiyuan He ***@***.***> wrote:
*hzy46* left a comment (microsoft/agent-lightning#670)
<#670 (comment)>
We do not need tests for examples. Please remove the tests and I will
merge this PR.
—
Reply to this email directly, view it on GitHub
<#670?email_source=notifications&email_token=B3CTYIGMCWOFPJJGLNG4QG35XAZQLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNJXGE2TKNRTG4YKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSWGM33PORSXEX3DNRUWG2Y#issuecomment-6571556370>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/B3CTYIAPOYS4OGX4IV3N5ML5XAZQLAVCNFSNUABGKJSXA33TNF2G64TZHMYTAMBUGE2DONRUGE5US43TOVSTWNRRGM2DOOJVGIZDFILWAI>
.
Triage notifications, keep track of coding agent tasks and review pull
requests on the go with GitHub Mobile for iOS
<https://github.com/notifications/mobile/ios/B3CTYIH6ZDHBNSBHNNWCXEL5XAZQLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNJXGE2TKNRTG4YKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSVGM33PORSXEX3JN5ZQ>
and Android
<https://github.com/notifications/mobile/android/B3CTYIB7YRXFYSAQ7IZIECL5XAZQLA5CNFSNUABFM5UWIORPF5TWS5BNNB2WEL2JONZXKZKDN5WW2ZLOOQXTMNJXGE2TKNRTG4YKM4TFMFZW63VKON2WE43DOJUWEZLEUVSXMZLOOSXGM33PORSXEX3BNZSHE33JMQ>.
Download it today!
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Author
|
Zhiyuan He (@hzy46) Thanks for the review! I've removed the example tests as requested and pushed the update in d154c7a. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #669.
In completion mode, overriding
actor_rollout_ref.model.pathchanges the training model but previously left the GSM8K and Search-R1 agents using the tokenizer copied before the override was merged. For example, Search-R1 could trainQwen/Qwen2.5-3B-Instructwhile its agent still encoded requests with the default Llama tokenizer.Use
${actor_rollout_ref.model.path}for both tokenizer defaults so they resolve against the final configuration. Explicit tokenizer environment overrides retain precedence. Document this behavior in both examples.Validation
On Windows with Python 3.12.10:
SSLKEYLOGFILEwas cleared only for the test process because the inherited local value points to an inaccessible log file.