Repository navigation
feat(service): expose standard gRPC health readiness (#3917) - #4190
Open
rudycelekli wants to merge 1 commit into
Open
rudycelekli wants to merge 1 commit into
rudycelekli wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Register grpc.health.v1.Health Check/Watch for the overall server and OpenMedService. Successful actual runtime preload publishes SERVING; terminal drain notification and stop publish NOT_SERVING, including when preload finishes after drain.
Type of Change
Testing
UV_NO_SYNC=1 UV_PROJECT_ENVIRONMENT=<shared Python 3.12 environment> PYTHONPATH=$PWD make format lint format-check type-check$OPENMED_TEST_ENV/bin/python -m pytest tests/ -qwith explicit worktreePYTHONPATH.Documentation
Code Quality
Dependencies
Pin grpcio-health-checking==1.81.1 in dev/service extras: upstream Apache-2.0 implementation of the standard health protocol. This matches the committed generated OpenMed stubs and existing lock versions. uv.lock adds only four requirement links; no package pins change. Core and Triton dependency groups stay unchanged.
Checklist
Related Issues
Closes #3917
Scope and example
Listener credentials and binding policy remain with #3546, coordinated admission/drain with #3576. Actual tests exercise ephemeral loopback and TLS listeners; no cluster deployment is claimed.