Repository navigation
Validate binary calibration target values - #3967
Open
maziyarpanahi wants to merge 18 commits into
Open
maziyarpanahi wants to merge 18 commits into
maziyarpanahi wants to merge 18 commits into
Conversation
maziyarpanahi
marked this pull request as ready for review
October 3, 2026 12:05
Retain POSIX private modes, Windows regular-file read/write checks and all-platform exclusive creation.
…3631) Keep the sensitive sentinel out of source excerpts while retaining message and full traceback-chain assertions.
Owner
Author
|
Thank you for the focused contribution for #3568. Its implementation and regression coverage already landed on This PR is held as superseded; the resolved issue provides no remaining implementation scope for another merge. I am retaining the original branch and discussion. Any additional behavior should be scoped to a new maintainer-backed issue before further changes or merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Accept calibration targets only as booleans or numeric zero/one. Non-empty strings such as
"false"must not silently become positive examples and distort calibration.This follows the report and immutable reproduction shared by Belal Embaby. The fix was reproduced against current upstream and implemented in existing tracked source/test files; the contributor's fork was not modified.
Type of Change
Changes Made
Testing
The published candidate is
1e797b14521d4e989a8c1221d1053666b553989c. It retains the issue contribution and normally integrates frozen SDK prerequisite5e635dd707ebd74c2d0806b0cb6415b53ab4d7b0from #3971. The issue-specific scope is unchanged; shared SDK/CI/build-budget changes belong to that prerequisite.make format,make lint,make format-check,make type-checkandgit diff --check: passed, without unrelated formatting changes.Post-integration full offline pytest passed on this exact head: 23,207 passed, 222 skipped, 24 warnings; zero failures/errors, in 448.15s. Local runtime: Python 3.13.11, with a private environment and unique OS temporary fixture directory. The full run captured exit 0 and the source remained clean and unchanged. Skips and warnings are not counted as executed passes. Earlier full receipts refer to older heads and are superseded only for this candidate.
SDK #3971 must still land and this exact pushed head must pass its own full local and hosted checks before merge. Hosted checks remain pending; this is not merge or release clearance. No tests or assertions were removed or weakened, and no skipped check or dependency waiver is introduced.
Documentation
Code Quality
Dependencies
Checklist
Related Issues
Closes #3568
Screenshots/Examples
Not applicable; backend/evaluation contract fix with synthetic unit coverage.