Repository navigation
Reject non-object catalog manifest rows - #3965
Open
maziyarpanahi wants to merge 18 commits into
Open
maziyarpanahi wants to merge 18 commits into
maziyarpanahi wants to merge 18 commits into
Conversation
Retain POSIX private modes, Windows regular-file read/write checks and all-platform exclusive creation.
…3631) Keep the sensitive sentinel out of source excerpts while retaining message and full traceback-chain assertions.
…e-3562-catalog-row-shapes
Owner
Author
|
Thank you for the focused contribution for #3562. Its implementation and regression coverage already landed on This PR is held as superseded; the resolved issue provides no remaining implementation scope for another merge. I am retaining the original branch and discussion. Any additional behavior should be scoped to a new maintainer-backed issue before further changes or merge. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Description
Reject non-object JSONL rows at catalog parsing so the public coherence check returns an actionable diagnostic instead of an AttributeError. Diagnostics contain physical line numbers only, not row values or paths.
This follows the report and immutable reproduction shared by Belal Embaby. The fix was reproduced against current upstream and implemented in existing tracked source/test files; the contributor's fork was not modified.
Type of Change
Changes Made
Testing
Current frozen head:
0d1cbb0f34b6b0afaad21191fa44a7192dd5a815. This branch normally merges the reviewed SDK prerequisite #3971 at5e635dd707ebd74c2d0806b0cb6415b53ab4d7b0, preserving the original commits. The only issue-specific integration edit moves this PR's existing changelog text unchanged into the existing Fixed section.Completed validation on this exact source, using Python 3.13.11 and a private environment:
make format,make lint,make format-check, andmake type-check: passed. The configured type check covers four modules; formatting introduced no changes.uv buildproduced the sdist and wheel; the wheel-size/install-profile gate passed: 7,036,403 / 7,739,665 bytes.pip_audit_gate.py: passed, no unreviewed vulnerabilities found. This does not qualify optional dependency profiles or grant an exception.git diff --check: passed.The full local suite on this post-SDK head is pending, and hosted checks on this pushed head remain pending. This is not merge or release clearance. Full discovery and normal failure semantics are retained; no skip, maxfail or failure-masking override was added.
Historical local full-suite receipt, from earlier prepared commit
6b397cf4c073c00581399170835ebe0e166aa21f: 23,125 passed, 222 skipped, 24 warnings, zero failures/errors, 410.23s. That earlier candidate contained SDK ancestor755f0eeebee2ba58764438263561ae077909e45c; it does not certify the new head above. Skips and warnings are reported as such, not counted as passed executions. The current full-suite result will replace this pending status when complete.#3971 is a shared prerequisite, not part of the issue's original implementation. Its dependency/build changes remain separately scoped. This PR must pass its own final local and hosted gates and wait for prerequisite integration before merge.
Documentation
Code Quality
Dependencies
Checklist
Related Issues
Closes #3562
Screenshots/Examples
Not applicable; backend/evaluation contract fix with synthetic unit coverage.