Repository navigation
Add lock profiler mode (--lock) - #586
Merged
Merged
Conversation
Adds a new sampler mode backed by async-profiler's "lock" event, which measures the time threads spend waiting on contended monitors (synchronized) and parked on java.util.concurrent locks. - new SamplerMode.LOCK / proto SamplerMode.LOCK = 2 - SampleCollector.Lock reads jdk.JavaMonitorEnter + jdk.ThreadPark events and converts their duration from ticks to nanoseconds - `/spark profiler start --lock`, with --interval used as the contention threshold in milliseconds (default 10us, same as async-profiler) - --ignore-sleeping is disabled in lock mode, as parked threads are exactly what is being measured
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a lock contention profiling mode using async-profiler's
lockevent.It measures time spent waiting on
synchronizedmonitors andjava.util.concurrentlocks.Usage:
/spark profiler start --lock. In this mode--intervalis thecontention threshold in milliseconds (default 10us).
Requires async-profiler, and
--ignore-sleepingis disabled in this mode.Viewer support: lucko/spark-viewer#94