Repository navigation
fix(requests): name a request's sender only when the Welcome proves it - #7
Merged
Merged
Conversation
A first-contact Welcome now carries the creator's root public key and the root key's binding of the device key (group context extension 0xF0A3). inspect_welcome requires, for a Welcome with a reply lane, that the user id is the fingerprint of that root key, that the binding verifies under it, names the credential's user and device, and binds the key that signed the Welcome. Otherwise the Welcome yields no preview, so the message request names no sender. The accept-time bundle check also requires the bundle's root key to equal the carried one. First contacts now require the new capability. A peer KeyPackage without it is refused with a clear error; a device's own last-resort KeyPackage without it is rotated at the next maintenance. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A message request showed its sender's name from the creator's self-asserted MLS credential before anything authenticated it.
A first-contact Welcome now carries the creator's root public key and the root key's binding of the device key (group-context extension
0xF0A3).inspect_welcomeaccepts a Welcome with a reply lane only if:Otherwise the Welcome gives no preview, and the request names no sender. The check is local: the receiver contacts no host. The accept-time bundle check is kept and now also requires the bundle's root key to equal the carried one.
First contacts now require the new capability:
Draft, opened so CI runs: this was not built locally.
🤖 Generated with Claude Code