Skip to content

[JOI-6/15] feat(server): add Friction Log API, CLI and MCP - #1936

Open
salmonumbrella wants to merge 63 commits into
kenn-io:mainfrom
salmonumbrella:feat/friction-log-pr06
Open

salmonumbrella wants to merge 63 commits into
kenn-io:mainfrom
salmonumbrella:feat/friction-log-pr06

Conversation

@salmonumbrella

@salmonumbrella salmonumbrella commented Sep 24, 2026 •

Copy link
Copy Markdown
Contributor

What changed

  • Exposes Friction Log digests, findings, and recurring patterns through HTTP, CLI, and read-only MCP tools.
  • Adds agentsview friction run to build missing completed days on demand, with date, rebuild, and dry-run options.

Why

The daily review is stored after PR05, but users and integrations still need a way to read it and request a catch-up run. These surfaces use the same stored data rather than separate review logic.

Usage

Run agentsview friction digest for the latest Markdown digest, agentsview friction findings for session findings, agentsview friction patterns for recurrence, or agentsview friction run to build missing days. HTTP and MCP clients can read the same results.

Part 6 of 15 in the stacked Friction Log series. Depends on #1935. GitHub shows the cumulative diff against main; review the PR06-only diff. Merge PR05 first. Refresh this branch against main and confirm its diff is scoped to PR06 before merging.

Refs #1908

@roborev-ci

roborev-ci Bot commented Sep 24, 2026

Copy link
Copy Markdown

roborev: Combined Review (0d0343f)

Verdict: Changes require fixes for 1 finding.

Medium

  • internal/friction/review/runner.go:418-423: Runner.CatchUp treats the maximum stored digest date as a contiguous watermark, so building a later complete day first can cause an earlier missing date in the backfill window to be skipped permanently. Iterate the bounded backfill range and skip only dates that already have a digest, or maintain and query a contiguous watermark. Add a regression test covering a later date built before an earlier missing date.

    Reported by: codex


Reviewers: 2 done | Synthesis: codex, 5s | Total: 20m45s

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant