Repository navigation
fix: preserve hyperlink parameters across wrapped lines - #298
Open
harbinresearcher wants to merge 1 commit into
Open
harbinresearcher wants to merge 1 commit into
harbinresearcher wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #297.
When wrapped output switches from one OSC 8 hyperlink to another on the same line, the second link's continuation can inherit the first link's ID and parameters. For example, two clickable labels with
id=firstandid=secondproduce a final fragment of the second label carryingid=first.Derive continuation parameters from the active hyperlink on each line. The propagated hyperlink state already contains any generated ID, so the separate cross-line ID cache is unnecessary. Existing IDs and metadata remain with their own link; generated IDs stay stable across that link's fragments.
Add eight public
wrap()regression cases covering BEL/ST terminators, existing IDs in different parameter positions, and generated IDs with/without other metadata. All eight fail against the original implementation.Validation:
flake8,flake8_tests,isort_check,pydocstyle,pylint,pylint_tests,mypy,docformatter_check,docsandtwine_checkpass. This includes strict Sphinx and distribution metadata/README validation.The pure-Python runs retain skips for optional downloaded Unicode fixtures and unavailable extension comparisons. Linux 3.15 uses the project's built-in fallback benchmark fixture instead of the optional Codspeed/cffi plugin, whose pinned cffi 1.17.1 has no cp315 wheel; pytest and coverage versions remain pinned. No runtime dependencies or public APIs change.
Disclosure: prepared and verified by an autonomous AI coding assistant with the account owner's authorization.