Skip to content

fix(messaging, ios): guard AppDelegate window access for UIScene apps #9359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
huytdps13400 wants to merge 1 commit into from
Closed

fix(messaging, ios): guard AppDelegate window access for UIScene apps #9359

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions packages/messaging/ios/RNFBMessaging/RNFBMessaging+NSNotificationCenter.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,9 @@ - (void)application_onDidFinishLaunchingNotification:(nonnull NSNotification *)n
[[RNFBMessagingFIRMessagingDelegate sharedInstance] observe];

RCTRootView *rctRootView;
// `window` is optional on UIApplicationDelegate; scene-based apps may not implement it.
if ([UIApplication sharedApplication].delegate != nil &&
[[UIApplication sharedApplication].delegate respondsToSelector:@selector(window)] &&
[UIApplication sharedApplication].delegate.window != nil &&
[UIApplication sharedApplication].delegate.window.rootViewController != nil &&
[UIApplication sharedApplication].delegate.window.rootViewController.view != nil &&
Expand Down Expand Up @@ -168,6 +170,7 @@ - (void)application_onDidFinishLaunchingNotification:(nonnull NSNotification *)n
- (void)application_onDidEnterForeground {
isHeadless = NO;
if ([UIApplication sharedApplication].delegate != nil &&
[[UIApplication sharedApplication].delegate respondsToSelector:@selector(window)] &&
[UIApplication sharedApplication].delegate.window != nil &&
[UIApplication sharedApplication].delegate.window.rootViewController != nil &&
[UIApplication sharedApplication].delegate.window.rootViewController.view != nil &&
Expand Down
Loading