Repository navigation
Conversation
cabljac
reviewed
Jan 7, 2026
cabljac
reviewed
Jan 7, 2026
cabljac
reviewed
Jan 7, 2026
cabljac
reviewed
Jan 7, 2026
cabljac
requested changes
Jan 7, 2026
cabljac
left a comment
cabljac
left a comment
Collaborator
There was a problem hiding this comment.
generally lgtm! nicely done. fairly minor comments
dackers86
reviewed
Jan 7, 2026
dackers86
reviewed
Jan 7, 2026
Member
Author
|
Ugh. Looks like there's an issue with VertexAI from using a diff Anthropic SDK version to it in the Anthropic testapps? |
cabljac
self-requested a review
January 12, 2026 09:38
CorieW
marked this pull request as ready for review
January 12, 2026 12:47
CorieW
force-pushed
the
add-prompt-caching-1
branch
from
January 12, 2026 15:03
f074f05 to
9b0a5bf
Compare
8 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes genkit-ai#3888
Test app covers: