Skip to content

P01 compute - #328

Open
desmonddak wants to merge 19 commits into
intel:mainfrom
desmonddak:P01_compute
Open

desmonddak wants to merge 19 commits into
intel:mainfrom
desmonddak:P01_compute

Conversation

@desmonddak

@desmonddak desmonddak commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Description & Motivation

Expand reusable compute primitives and their documentation:

  • Add unsigned accumulation, numeric narrowing, divider core and ready/valid wrapper, a valid-only carry-save multiplier wrapper, and fixes for divider nontermination at certain operand widths and signed inputs.
  • Add a protocol-neutral fixed-latency tracker and a generic ready/valid wrapper with initiation-interval scheduling, reserved result buffering, and optional IDs for in-order, continuously advancing cores.
  • Add opt-in 4:2 compression trees, configurable per-input/output delay estimates for multipliers, multiply-accumulates, and dot products, and fix pipelined compression-tree MAC control ports.
  • Add GF(2) algebra and finite fields, linear transforms, LFSRs including a zero-based tap-list API, signatures, and seed-aligned PRBS generation and checking.
  • Add floating-point classification and comparison, opt-in explicit-J alignment, configurable prefix scans including Gray-code conversion, first-match selection, boolean scatter, thermometer conversion, and a clock-enable divider.
  • Add one-hot/binary extensions, strict-majority hardware reused by compressor carries, and opt-in aligned serializer timing. Extend Confapp and source views for compute and binary-math components, custom compression delays, and serializer alignment; the generic fixed-latency entry is a delay-core example.
  • Fix AXI4 handshake sampling and queued writes. Add an opt-in ACE4 signal layout and signal-level BFM support, and typed resettable-entry controls.
  • Audit typed payloads across arithmetic, dataflow, interfaces, flow control, memory, cache, clocking, protection, and SPI. Preserve declared structures and semantic formats through ports, storage, and operations, including structured constants and IDs widened to Logic.
  • Reject incompatible declared payloads and malformed clones while retaining explicit packed-vector bridges. Add typed alternatives for priority selection, associative matching and side reads, and SPI; keep the existing flat APIs as deprecated compatibility paths.
  • Share recursive clone and semantic-shape validation with ROHD. The accompanying local ROHD changes also preserve structured constants by default in addTypedInput and fix structured FlipFlop<Logic> outputs.
  • Move durable component-selection and contributor guidance into the README-linked documentation.

Related Issue(s)

Testing

  • The existing PR reports a local dart test run.
  • Focused AXI4, ACE4, resettable-entry, and static/runtime control tests: 73 passed.
  • Typed storage and control regression tests: 72 passed, including generated RTL and SystemC cases.
  • Serializer regression tests: 36 passed.
  • One-hot and configurator regression tests: 144 passed.
  • Divider and wrapper tests: 11 passed, including exhaustive 1- through 4-bit signed and unsigned operands and directed ROHD, Icarus, and Verilator checks.
  • Binary recurrence tests: 10 passed, including tap-list sequences, controls, validation, and generated RTL.
  • Compression-tree, multiplier, MAC, dot-product, and configurator tests: 216 passed, including 4:2 selection, all compressor inputs, mixed configurations, and pipeline controls.
  • Configurable compression-delay and column-compressor tests: 18 passed, including asymmetric pin paths, mixed configurations, irregular rows, and generated RTL. Additional multiplier, MAC, and dot-product regressions: 351 passed.
  • Majority, population-count, and compressor regressions: 37 passed, including exhaustive small-width X/Z inputs, wider vectors, shared three-input carry logic, and generated RTL.
  • Confapp configurator regressions: 165 passed, including default generation, non-default round trips, custom delays, and aligned serializer timing. Focused Confapp widget and source-mapping tests passed, including the generated asset bundle.
  • Fixed-latency tracker and wrapper tests: 14 passed, including ROHD simulation, generated Icarus RTL, multi-cycle cores, backpressure, reset, throughput, and typed payloads. Queue and handshake contract regressions: 50 passed.
  • Latest focused typed-payload regressions: 711 passed using the local ROHD changes: 602 HCL tests and 109 ROHD tests. These cover clone and port validation, structured constants, typed arrays, fixed-latency IDs, divider schemas, dataflow, control, transport, and memory, including generated Icarus and Verilator RTL checks.
  • Wasm smoke tests: 2 passed in Chrome and 2 in Node in an isolated HCL-only package; 2 also passed on the Dart VM. The shared workspace uses Chrome for the CI smoke test.
  • Targeted Dart analysis, Markdown lint, and whitespace checks passed.
  • Broader pre-merge validation: to be completed.

Backwards-compatibility

Is this a breaking change that will not be backwards-compatible? If yes, how so?

Existing serializer and ACE4 layouts remain the defaults; aligned timing and the ACE4 signal layout are opt-in. Explicit-J alignment and Gray prefix topology are also opt-in. AXI4 monitor sampling is corrected to capture values at the handshake edge. Divider cases that previously failed to complete now produce results; the public divider interface and logDataWidth value are unchanged.

Typed payload validation intentionally rejects incompatible declared formats and clones that change a declared type or recursive shape. Existing plain packed-vector bridges remain supported. Flat APIs with typed replacements remain available but are deprecated.

The accompanying ROHD change is a minor breaking change: addTypedInput now preserves constant-containing structures widened to Logic by default. Callers requiring the previous flattened behavior can set preserveStructuredConstants: false. ROHD also validates declared clone shapes in cloneTyped, addTypedInput, and addTypedInOut.

The existing case-based one-hot decoder can produce different X/Z results in ROHD simulation and generated RTL; the value extension follows ROHD simulation. The ACE4 checker covers signal-level behavior, not full coherency compliance.

Documentation

Does the change require any updates to documentation? If so, where? Are they included?

Updated the component index and topic guides, contributor guidance, and CHANGELOG.md. The compute-family development page is retired in favor of permanent component documentation.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant