Repository navigation
P01 compute - #328
Open
desmonddak wants to merge 19 commits into
Open
P01 compute#328desmonddak wants to merge 19 commits into
desmonddak wants to merge 19 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description & Motivation
Expand reusable compute primitives and their documentation:
Logic.addTypedInputand fix structuredFlipFlop<Logic>outputs.Related Issue(s)
extensions for converting to/from one-hot/binary #19: Add one-hot/binary extensions forLogicandLogicValue.LogicValue.majority()API.Serializerto have the same output latency with or withoutflopInput#149: Add opt-in aligned serializer output timing while preserving existing defaults.Testing
dart testrun.Backwards-compatibility
Existing serializer and ACE4 layouts remain the defaults; aligned timing and the ACE4 signal layout are opt-in. Explicit-J alignment and Gray prefix topology are also opt-in. AXI4 monitor sampling is corrected to capture values at the handshake edge. Divider cases that previously failed to complete now produce results; the public divider interface and
logDataWidthvalue are unchanged.Typed payload validation intentionally rejects incompatible declared formats and clones that change a declared type or recursive shape. Existing plain packed-vector bridges remain supported. Flat APIs with typed replacements remain available but are deprecated.
The accompanying ROHD change is a minor breaking change:
addTypedInputnow preserves constant-containing structures widened toLogicby default. Callers requiring the previous flattened behavior can setpreserveStructuredConstants: false. ROHD also validates declared clone shapes incloneTyped,addTypedInput, andaddTypedInOut.The existing case-based one-hot decoder can produce different X/Z results in ROHD simulation and generated RTL; the value extension follows ROHD simulation. The ACE4 checker covers signal-level behavior, not full coherency compliance.
Documentation
Updated the component index and topic guides, contributor guidance, and
CHANGELOG.md. The compute-family development page is retired in favor of permanent component documentation.