Skip to content

all: Bump locked dependencies to fix RustSec advisories - #6788

Open
dimitrovmaksim wants to merge 1 commit into
masterfrom
fix/rustsec-lockfile-updates
Open

dimitrovmaksim wants to merge 1 commit into
masterfrom
fix/rustsec-lockfile-updates

Conversation

@dimitrovmaksim

@dimitrovmaksim dimitrovmaksim commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Lockfile-only update for the RustSec advisories that graph-node can reach and that have a lockfile-only fix with no known silent regression. It also bumps crates that aren't compiled into any graph-node or gnd binary. There are no Cargo.toml or source changes.

This fixes 20 of the 49 vulnerability advisories cargo audit reports on master. The audit stays red after merge:

  • 29 vulnerabilities remain. Each one is listed under Not included with the reason.
  • 16 unsound and 6 unmaintained informational advisories are not addressed here.

RUSTSEC-2026-0379 (wasmtime, critical) is reachable on aarch64 and is not fixed here. See Not included.

Inclusion rule

  • Bump when graph-node can reach the advisory and the fix is lockfile-only, or when the crate isn't compiled into any graph-node or gnd binary (zero runtime effect).
  • Don't bump:
    • compiled crates whose advisory graph-node can't reach (a runtime change for no gain);
    • fixes that need Cargo.toml or toolchain changes;
    • fixes that bring a silent regression.
  • How regressions are weighed:
    • Accepted: changes that fail loudly at startup or connect time and that an operator can work around. The webpki-roots root removals fail at startup; switch the provider to https://. The SCRAM cap fails at login; re-set the role's password with fewer iterations.
    • Rejected: changes that fail silently at runtime with no operator setting. h2's hard-coded DATA-frame limits mean connection resets mid-stream.
  • Versions: the minimum fixed version, with two exceptions:
    • webpki-roots 1.0.11, one release past the 1.0.10 minimum. It also drops the emSign C1/C3 roots from eMudhra, the CA operator behind the intermediates that RUSTSEC-2026-0381/-0382 distrust; requested on deps: Bump dependencies to fix RustSec advisories #6746.
    • webpki-root-certs 1.0.11, to match. It isn't compiled anyway.

Closes

Supersedes:

Changes (Cargo.lock only)

Crate From → To Advisories
rustls 0.23.41 → 0.23.46 RUSTSEC-2026-0285, -0346, -0348, -0349
rustls-webpki 0.103.13 → 0.103.16 RUSTSEC-2026-0382
webpki-roots 1.0.5 → 1.0.11 RUSTSEC-2026-0381 (fixed in ≥1.0.10); see the inclusion rule for 1.0.11
webpki-root-certs 1.0.7 → 1.0.11 RUSTSEC-2026-0383 (compiled for no target)
postgres-protocol 0.6.9 → 0.6.12 RUSTSEC-2026-0179, -0180
tokio-postgres 0.7.15 → 0.7.18 RUSTSEC-2026-0178
quinn-proto 0.11.14 → 0.11.19 RUSTSEC-2026-0185, -0338, -0339, -0340, -0342, -0523, -0524
quinn-udp 0.5.14 → 0.5.16 RUSTSEC-2026-0538
pulldown-cmark 0.13.0 → 0.13.6 RUSTSEC-2026-0414, -0433

Transitive changes:

  • rustls ≥0.23.44 and rustls-webpki 0.103.16 need aws-lc-rs ^1.18: aws-lc-rs 1.16.3 → 1.18.2, aws-lc-sys 0.40.0 → 0.46.0, pkg-config 0.3.30 → 0.3.34 (aws-lc-sys ≥0.44 requires ^0.3.31).
  • tokio-postgres 0.7.18 and postgres-protocol 0.6.12:
    • postgres-types 0.2.11 → 0.2.14
    • whoami 1.5.1 → 2.1.3, with wasite 0.1.0 → 1.0.2, libredox 0.1.3 → 0.1.25, new objc2-core-foundation and objc2-system-configuration (macOS), and redox_syscall 0.4.1 dropped
    • md-5 0.10.6 → 0.11.0; new hmac 0.13.0 (0.12.1 stays for rfc6979) with cmov and ctutils; digest gains ctutils
    • The postgres crates move from rand 0.9 / sha2 0.10 to rand 0.10 / sha2 0.11, which were already in the lock.
  • quinn-proto: new rand_pcg 0.10.2; moves to getrandom 0.4 / rand 0.10, which were already in the lock.
  • Dependency edges re-resolved by Cargo, with no version added:
    • windows-sys edges move to 0.61.2, which was already in the lock (Windows only): rustix, tempfile and rustls-platform-verifier from 0.52.0; anstyle-wincon and quinn-udp from 0.60.2.
    • getrandom's js-sys/wasm-bindgen and parking_lot_core's redox_syscall edges are re-pinned (wasm and Redox only).

Reproduce from master. This gives a byte-identical Cargo.lock as of 2026-11-16. The first command has no --precise, so later runs may pick newer patch versions.

cargo update -p quinn-proto -p quinn-udp -p pulldown-cmark -p postgres-protocol \
  -p tokio-postgres -p postgres-types -p libredox -p pkg-config
cargo update -p webpki-roots@1.0.5 --precise 1.0.11
cargo update -p webpki-root-certs --precise 1.0.11
cargo update -p aws-lc-rs --precise 1.18.2
cargo update -p rustls-webpki --precise 0.103.16
cargo update -p rustls --precise 0.23.46

Reachability

Issues Reachable? Why
rustls #6778, #6779; rustls-webpki #6781 Yes Outbound TLS through rustls: tonic (Firehose, Substreams, Amp Flight), object_store (GCS metrics upload), tokio-tungstenite (wss:// RPC). HTTPS JSON-RPC uses graph's own reqwest 0.12 with native-tls, so neither change affects it.
rustls #6777, #6780 No The brotli feature is off, and there's no custom ClientSessionStore. Fixed by the same bump.
postgres-protocol #6623, tokio-postgres #6625 Yes, from a malicious or MITM'd Postgres server tokio-postgres is the client behind diesel-async and the notification listener.
postgres-protocol #6624 (hstore) No graph-node doesn't use hstore. Fixed by the same bump.
quinn-proto / quinn-udp No In Cargo.lock only through reqwest's optional http3. Not compiled for any target or feature set (cargo tree --workspace --all-features --target all -i quinn-proto is empty).
pulldown-cmark No Build-time only: prost-build renders doc comments of our own .proto files.
webpki-roots Yes wss:// RPC only: alloy's WS transport uses tokio-tungstenite, built with rustls-tls-webpki-roots. Everything else uses the OS trust store: HTTPS JSON-RPC (native-tls), tonic (tls-native-roots), and object_store (rustls-platform-verifier).
webpki-root-certs No Compiled for no target: reqwest only pulls rustls-platform-verifier on non-wasm32, and that only pulls webpki-root-certs on wasm32.

Behaviour changes

  • Removed root CAs can stop the node from starting. The new webpki-roots removes 22 roots and adds 5. If a wss:// provider's certificate chains only to a removed root, the connect in EthereumAdapter::new panics at startup (.expect("Failed to connect to Ethereum WS"), chain/ethereum/src/ethereum_adapter.rs). That takes down every chain, not just that provider's. curl https://<same host> still works because it uses the OS store, so it won't show the cause.
    • Check before upgrading: run openssl s_client -connect <host>:443 -showcerts </dev/null and look at the root of the chain.
    • Workaround: switch that provider to https://.
    • Removed: Atos TrustedRoot 2011; Certigna; certSIGN ROOT CA; COMODO Certification Authority; DigiCert Assured ID Root CA; DigiCert Global Root CA; DigiCert High Assurance EV Root CA; emSign ECC Root CA - C3; emSign ECC Root CA - G3; emSign Root CA - C1; FIRMAPROFESIONAL CA ROOT-A WEB; GTS Root R2; QuoVadis Root CA 2; QuoVadis Root CA 3; Secure Global CA; SecureSign Root CA12; SecureTrust CA; SwissSign Gold CA - G2; TeliaSonera Root CA v1; Trustwave Global Certification Authority; Trustwave Global ECC P256 Certification Authority; Trustwave Global ECC P384 Certification Authority.
    • Added: e-Szigno TLS Root CA 2023; SECOM TLS ECC Root CA 2024; SECOM TLS RSA Root CA 2024; Telia EC TLS Root CA v3; Telia RSA TLS Root CA v3.
  • rustls:
    • Stricter TLS 1.3 handshake checks: handshake messages that span key changes and protected change_cipher_spec records are now rejected.
    • ML-DSA signature verification is on by default, so every outbound ClientHello now advertises ML-DSA in signature_algorithms.
  • rustls-webpki: rejects certificate paths that contain the compromised emSign intermediate keys, whatever the trust anchors.
  • tokio-postgres / postgres-protocol:
    • Malformed server data now returns an error instead of panicking.
    • The SCRAM iteration count is capped at 100,000. A role whose stored SCRAM verifier uses more can no longer authenticate, and this may only show up as a generic authentication error. The count is fixed when the password is set; on PG16+ it comes from scram_iterations.
      • Check (superuser): SELECT rolname, split_part(split_part(rolpassword, '$', 2), ':', 1)::int AS iterations FROM pg_authid WHERE rolpassword LIKE 'SCRAM-SHA-256$%';
      • Fix: lower scram_iterations and set the password again.
    • The bind-parameter limit rises from i16::MAX to u16::MAX. graph-node is unaffected because it caps itself at i16::MAX (POSTGRES_MAX_PARAMETERS).
  • whoami 2: only used when the connection URL has no user. If the OS user can't be resolved, this is now an I/O error instead of the "unknown" fallback; the connection failed in either case.
  • aws-lc-sys 0.46: the build script can link a system AWS-LC that it detects through OPENSSL_DIR or pkg-config. It only accepts a library carrying the OPENSSL_IS_AWSLC marker. AWS_LC_SYS_USE_SYSTEM=0 forces the vendored build.

Not included

All 29 vulnerability advisories that remain after this PR, plus the unsound ones with open issues:

Item Why
wasmtime RUSTSEC-2026-0379 (aarch64 Cranelift br_table, critical) Reachable on aarch64: graph-node forces Cranelift (runtime/wasm/src/mapping.rs) on untrusted subgraph Wasm.
Exposed: self-built aarch64 indexers. The repo's image build (docker/cloudbuild.yaml) targets no arm64, and gnd's aarch64 binaries run the developer's own Wasm. x86_64 isn't affected.
Fixed in 36.0.19 (LTS line; a Cargo.toml downgrade from 46), ≥48.0.7 (needs Rust ≥1.95) or ≥49.0.4 (needs Rust ≥1.96). The toolchain is pinned to 1.94.0 because of rust-lang/rust#152942, which is reported fixed in Rust 1.100.0 (released 2026-11-12) but not yet verified against graph-node. Dependabot #6753 has the 48.0.7 bump.
h2 RUSTSEC-2026-0258 (#6766, Low) Reachable as a client (tonic: Firehose, Substreams, Amp) and as a server (the admin JSON-RPC and graphman ports: axum::serve → hyper-util auto::Builder with HTTP/2 enabled, so they accept unencrypted HTTP/2).
No released fix avoids a regression:
• 0.4.16–0.4.18 use a fixed 25,600-byte budget for small DATA frames, which disconnected real streaming clients (hyperium/h2#944).
• 0.4.19+ scale that budget but add a hard-coded, never-reset cap of 100 empty DATA frames per connection, which GCS downloads hit (hyperium/h2#961).
Either way, one GOAWAY drops every stream on the connection; a Firehose connection carries up to 100 subgraphs. The proposed fix, hyperium/h2#972, has no reviews, and the maintainer considers it a server-side bug.
Revisit when h2 ships a release that fixes #961.
wasmtime component model: RUSTSEC-2026-0316, -0327, -0353 (#6786), -0354, -0355, -0356 (#6785), -0357, -0358 (#6783), -0361, -0363 (#6784), -0378, -0424 (#6782) Not reachable: graph-node only loads core modules (Module::from_binary); there's no wasmtime::component use. Fixed only in ≥48.x (same toolchain blocker) or the 36.x LTS line.
wasmtime RUSTSEC-2026-0359 Not reachable: it needs guest-defined chains of recursive (GC) types. The gas-injection pass (parity-wasm, MVP + sign-ext only) rejects such modules before wasmtime sees them. Fixed only in ≥48.0.6.
wasmtime RUSTSEC-2026-0362 Not reachable: it needs host code that re-enters Wasm through sync calls during an async call. graph-node only calls into Wasm with call_async. Fixed only in ≥48.0.6.
wasmtime RUSTSEC-2026-0222, -0223, -0268, -0269 (#6787) Not reachable. Fixed in 46.0.3, but not bumped because the crate is compiled and the advisories are unreachable:
• -0222: Store::new always gets the module's own Engine.
• -0223: parity-wasm's bulk feature is off, so bulk-memory opcodes are rejected at gas injection; each trigger gets a fresh Store with no epoch callback.
• -0268 / -0269: WASI only; wasmtime-wasi and cap-std aren't in the tree.
ruint RUSTSEC-2026-0220 (#6776) Not reachable: graph-node calls none of the affected checked/overflowing/saturating/wrapping/strict shifts or byte(), and BigInt shifts use num-bigint with u8 amounts. The fixed versions (≥1.20.0) also change other arithmetic edge cases.
quick-xml RUSTSEC-2026-0194, -0195 (#6673, #6674) Not reachable: object_store parses XML only for GCS list and multipart responses, and graph-node only calls put (graph/src/components/metrics/block_state.rs).
crossbeam-epoch RUSTSEC-2026-0204 (#6672) Not reachable: nothing formats an Atomic or Shared with {:p}.
crypto-bigint RUSTSEC-2026-0387 (#6765) Not reachable: it's only used through k256/alloy-signer, and graph-node does no secret-key operations outside tests.
zstd RUSTSEC-2026-0391, zstd-safe -0398 / -0403, zstd-sys -0410 (no issues) Not reachable:
• zstd is built with no features, so seekable (-0398) and legacy (-0403) are off.
• -0410 is the wasm allocator shim.
• parquet uses the bulk API, not the stream with_context constructors (-0391), and wasmtime's compilation cache, the other zstd user, isn't configured.
Lockfile-only fixes exist (zstd 0.13.4, zstd-safe 7.4.0, zstd-sys 2.1.2).
diesel RUSTSEC-2026-0172 (#6619, unsound) Not reachable: the SQLite backend isn't enabled (Postgres features only).
event-listener RUSTSEC-2026-0221 (unsound, no issue) Not reachable: the only listener! user is async-lock (via redis), which uses the default () tag. The advisory needs a non-Send tag.
alloy 2.5 / alloy-core 1.7.3 In #6746. Covers #6618 (proc-macro-error2) and lru RUSTSEC-2026-0253 (no issue). Changes the block-hash param encoding (alloy-rs/alloy#4052) and ABI decoding.

Testing

Run locally on macOS (aarch64) against the lockfile above:

  • just format: no changes
  • just lint: 0 warnings
  • just check --release: ok. The generated protobuf sources are unchanged after the build.
  • just test-unit: 60 suites, 1484 passed, 0 failed, 8 ignored

CI:

  • CI's Postgres sets POSTGRES_PASSWORD, so the image writes host … scram-sha-256 and the unit tests run the SCRAM success path.
  • The first "Run integration tests" run on this head failed in topic-filter: it got 1 of the 2 expected anotherTriggerEntities. This lockfile change doesn't touch indexing or query code, and the previous head and master passed, so it looks like a flaky test. It passed on re-run.

Not covered:

  • md5 auth and the >100,000-iteration rejection.
  • TLS, HTTP/2 and wss:// behaviour; there are no tests for them.
  • Windows, aarch64 Linux and x86_64 macOS builds. gnd-binary-build wasn't run, so the Windows windows-sys 0.61.2 edges are unbuilt. The local macOS build compiled the objc2 additions.

Lockfile-only update: rustls 0.23.46, rustls-webpki 0.103.16,
webpki-roots 1.0.11, webpki-root-certs 1.0.11,
postgres-protocol 0.6.12, tokio-postgres 0.7.18,
quinn-proto 0.11.19, quinn-udp 0.5.16, pulldown-cmark 0.13.6,
plus the transitive bumps they require (aws-lc-rs 1.18.2,
aws-lc-sys 0.46.0, pkg-config 0.3.34, whoami 2.1.3).
@dimitrovmaksim
dimitrovmaksim force-pushed the fix/rustsec-lockfile-updates branch from 650271e to 58894b4 Compare November 16, 2026 16:17
@dimitrovmaksim dimitrovmaksim added security Pull requests that address a security vulnerability dependencies Pull requests that update a dependency file labels Nov 16, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment