Repository navigation
all: Bump locked dependencies to fix RustSec advisories - #6788
Open
dimitrovmaksim wants to merge 1 commit into
Open
dimitrovmaksim wants to merge 1 commit into
dimitrovmaksim wants to merge 1 commit into
Conversation
Lockfile-only update: rustls 0.23.46, rustls-webpki 0.103.16, webpki-roots 1.0.11, webpki-root-certs 1.0.11, postgres-protocol 0.6.12, tokio-postgres 0.7.18, quinn-proto 0.11.19, quinn-udp 0.5.16, pulldown-cmark 0.13.6, plus the transitive bumps they require (aws-lc-rs 1.18.2, aws-lc-sys 0.46.0, pkg-config 0.3.34, whoami 2.1.3).
dimitrovmaksim
force-pushed
the
fix/rustsec-lockfile-updates
branch
from
November 16, 2026 16:17
650271e to
58894b4
Compare
This was referenced Nov 16, 2026
RUSTSEC-2026-0220: Uint shift operations: incorrect overflow flags and truncated shift amounts
#6776
Closed
Closed
Closed
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lockfile-only update for the RustSec advisories that graph-node can reach and that have a lockfile-only fix with no known silent regression. It also bumps crates that aren't compiled into any graph-node or gnd binary. There are no
Cargo.tomlor source changes.This fixes 20 of the 49 vulnerability advisories
cargo auditreports on master. The audit stays red after merge:RUSTSEC-2026-0379 (wasmtime, critical) is reachable on aarch64 and is not fixed here. See Not included.
Inclusion rule
Cargo.tomlor toolchain changes;https://. The SCRAM cap fails at login; re-set the role's password with fewer iterations.webpki-roots1.0.11, one release past the 1.0.10 minimum. It also drops the emSign C1/C3 roots from eMudhra, the CA operator behind the intermediates that RUSTSEC-2026-0381/-0382 distrust; requested on deps: Bump dependencies to fix RustSec advisories #6746.webpki-root-certs1.0.11, to match. It isn't compiled anyway.Closes
rustlsBrotli certificate decompressionrustlsServerHello key-share downgraderustlsTLS 1.3 messages across encryption levelsDebugimpls for client session values expose TLS secrets #6780 — RUSTSEC-2026-0346rustlsDebugexposes session secretsrustls-webpkidistrusted emSign intermediatespostgres-protocolunbounded SCRAM iterationshstorevalue allows denial of service #6624 — RUSTSEC-2026-0180postgres-protocolhstore panicDataRowwith fewer fields than columns allows denial of service #6625 — RUSTSEC-2026-0178tokio-postgresDataRow panicquinn-protoquinn-protoquinn-protoquinn-protoquinn-protoquinn-protoquinn-protoquinn-udpENABLE_WIKILINKS#6767 — RUSTSEC-2026-0414pulldown-cmarkENABLE_WIKILINKS#6768 — RUSTSEC-2026-0433pulldown-cmarkSupersedes:
Changes (
Cargo.lockonly)Transitive changes:
aws-lc-rs1.16.3 → 1.18.2,aws-lc-sys0.40.0 → 0.46.0,pkg-config0.3.30 → 0.3.34 (aws-lc-sys ≥0.44 requires^0.3.31).postgres-types0.2.11 → 0.2.14whoami1.5.1 → 2.1.3, withwasite0.1.0 → 1.0.2,libredox0.1.3 → 0.1.25, newobjc2-core-foundationandobjc2-system-configuration(macOS), andredox_syscall0.4.1 droppedmd-50.10.6 → 0.11.0; newhmac0.13.0 (0.12.1 stays forrfc6979) withcmovandctutils;digestgainsctutilsrand0.9 /sha20.10 torand0.10 /sha20.11, which were already in the lock.rand_pcg0.10.2; moves togetrandom0.4 /rand0.10, which were already in the lock.windows-sysedges move to 0.61.2, which was already in the lock (Windows only):rustix,tempfileandrustls-platform-verifierfrom 0.52.0;anstyle-winconandquinn-udpfrom 0.60.2.getrandom'sjs-sys/wasm-bindgenandparking_lot_core'sredox_syscalledges are re-pinned (wasm and Redox only).Reproduce from master. This gives a byte-identical
Cargo.lockas of 2026-11-16. The first command has no--precise, so later runs may pick newer patch versions.Reachability
wss://RPC). HTTPS JSON-RPC uses graph's own reqwest 0.12 with native-tls, so neither change affects it.brotlifeature is off, and there's no customClientSessionStore. Fixed by the same bump.Cargo.lockonly through reqwest's optionalhttp3. Not compiled for any target or feature set (cargo tree --workspace --all-features --target all -i quinn-protois empty)..protofiles.wss://RPC only: alloy's WS transport uses tokio-tungstenite, built withrustls-tls-webpki-roots. Everything else uses the OS trust store: HTTPS JSON-RPC (native-tls), tonic (tls-native-roots), and object_store (rustls-platform-verifier).rustls-platform-verifieron non-wasm32, and that only pullswebpki-root-certson wasm32.Behaviour changes
webpki-rootsremoves 22 roots and adds 5. If awss://provider's certificate chains only to a removed root, the connect inEthereumAdapter::newpanics at startup (.expect("Failed to connect to Ethereum WS"),chain/ethereum/src/ethereum_adapter.rs). That takes down every chain, not just that provider's.curl https://<same host>still works because it uses the OS store, so it won't show the cause.openssl s_client -connect <host>:443 -showcerts </dev/nulland look at the root of the chain.https://.change_cipher_specrecords are now rejected.signature_algorithms.scram_iterations.SELECT rolname, split_part(split_part(rolpassword, '$', 2), ':', 1)::int AS iterations FROM pg_authid WHERE rolpassword LIKE 'SCRAM-SHA-256$%';scram_iterationsand set the password again.i16::MAXtou16::MAX. graph-node is unaffected because it caps itself ati16::MAX(POSTGRES_MAX_PARAMETERS)."unknown"fallback; the connection failed in either case.OPENSSL_DIRor pkg-config. It only accepts a library carrying theOPENSSL_IS_AWSLCmarker.AWS_LC_SYS_USE_SYSTEM=0forces the vendored build.Not included
All 29 vulnerability advisories that remain after this PR, plus the unsound ones with open issues:
br_table, critical)runtime/wasm/src/mapping.rs) on untrusted subgraph Wasm.Exposed: self-built aarch64 indexers. The repo's image build (
docker/cloudbuild.yaml) targets no arm64, and gnd's aarch64 binaries run the developer's own Wasm. x86_64 isn't affected.Fixed in 36.0.19 (LTS line; a
Cargo.tomldowngrade from 46), ≥48.0.7 (needs Rust ≥1.95) or ≥49.0.4 (needs Rust ≥1.96). The toolchain is pinned to 1.94.0 because of rust-lang/rust#152942, which is reported fixed in Rust 1.100.0 (released 2026-11-12) but not yet verified against graph-node. Dependabot #6753 has the 48.0.7 bump.axum::serve→ hyper-utilauto::Builderwith HTTP/2 enabled, so they accept unencrypted HTTP/2).No released fix avoids a regression:
• 0.4.16–0.4.18 use a fixed 25,600-byte budget for small DATA frames, which disconnected real streaming clients (hyperium/h2#944).
• 0.4.19+ scale that budget but add a hard-coded, never-reset cap of 100 empty DATA frames per connection, which GCS downloads hit (hyperium/h2#961).
Either way, one GOAWAY drops every stream on the connection; a Firehose connection carries up to 100 subgraphs. The proposed fix, hyperium/h2#972, has no reviews, and the maintainer considers it a server-side bug.
Revisit when h2 ships a release that fixes #961.
Module::from_binary); there's nowasmtime::componentuse. Fixed only in ≥48.x (same toolchain blocker) or the 36.x LTS line.call_async. Fixed only in ≥48.0.6.• -0222:
Store::newalways gets the module's ownEngine.• -0223: parity-wasm's
bulkfeature is off, so bulk-memory opcodes are rejected at gas injection; each trigger gets a freshStorewith no epoch callback.• -0268 / -0269: WASI only;
wasmtime-wasiandcap-stdaren't in the tree.checked/overflowing/saturating/wrapping/strictshifts orbyte(), andBigIntshifts use num-bigint withu8amounts. The fixed versions (≥1.20.0) also change other arithmetic edge cases.put(graph/src/components/metrics/block_state.rs).AtomicorSharedwith{:p}.• zstd is built with no features, so
seekable(-0398) andlegacy(-0403) are off.• -0410 is the wasm allocator shim.
• parquet uses the
bulkAPI, not the streamwith_contextconstructors (-0391), and wasmtime's compilation cache, the other zstd user, isn't configured.Lockfile-only fixes exist (zstd 0.13.4, zstd-safe 7.4.0, zstd-sys 2.1.2).
listener!user is async-lock (via redis), which uses the default()tag. The advisory needs a non-Sendtag.proc-macro-error2) andlruRUSTSEC-2026-0253 (no issue). Changes the block-hash param encoding (alloy-rs/alloy#4052) and ABI decoding.Testing
Run locally on macOS (aarch64) against the lockfile above:
just format: no changesjust lint: 0 warningsjust check --release: ok. The generated protobuf sources are unchanged after the build.just test-unit: 60 suites, 1484 passed, 0 failed, 8 ignoredCI:
POSTGRES_PASSWORD, so the image writeshost … scram-sha-256and the unit tests run the SCRAM success path.topic-filter: it got 1 of the 2 expectedanotherTriggerEntities. This lockfile change doesn't touch indexing or query code, and the previous head and master passed, so it looks like a flaky test. It passed on re-run.Not covered:
wss://behaviour; there are no tests for them.gnd-binary-buildwasn't run, so the Windowswindows-sys0.61.2 edges are unbuilt. The local macOS build compiled theobjc2additions.