Repository navigation
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for requesting the ML-KEM-1024 post-quantum cryptography algorithm. It adds documentation, updates the REST client to prepend MLKEM1024 when the GOOGLE_CLOUD_CPP_ENABLE_ML_KEM_1024 environment variable is set, and includes integration and unit tests. Feedback on the changes suggests using std::rotate for a more efficient in-place element move in ssl_ec_curves.cc, using structured bindings in map loops, and avoiding the use of auto when it obscures StatusOr return types in tests to align with the repository style guide.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #16571 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 2266 2266
Lines 219458 219516 +58
=======================================
+ Hits 202771 202828 +57
- Misses 16687 16688 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Allow users to opt in to prioritizing MLKEM1024 for REST TLS 1.3 connections via the GOOGLE_CLOUD_CPP_ENABLE_ML_KEM_1024 environment variable, keeping X25519MLKEM768 in the fallback list. Also document how to request ML-KEM-1024 for both REST and gRPC transports.
c6f8d7d to
1cdf179
Compare
Prioritize
MLKEM1024(keepingX25519MLKEM768as fallback) inCURLOPT_SSL_EC_CURVESwhenGOOGLE_CLOUD_CPP_ENABLE_ML_KEM_1024is set, and documentML-KEM-1024configuration for REST and gRPC.