Skip to content

impl(rest): support ML-KEM-1024 when requested - #16571

Closed
colinmoy wants to merge 2 commits into
googleapis:mainfrom
colinmoy:feat-pqc-mlkem1024
Closed

colinmoy wants to merge 2 commits into
googleapis:mainfrom
colinmoy:feat-pqc-mlkem1024

Conversation

@colinmoy

Copy link
Copy Markdown
Collaborator

Prioritize MLKEM1024 (keeping X25519MLKEM768 as fallback) in CURLOPT_SSL_EC_CURVES when GOOGLE_CLOUD_CPP_ENABLE_ML_KEM_1024 is set, and document ML-KEM-1024 configuration for REST and gRPC.

@colinmoy
colinmoy requested a review from a team as a code owner October 15, 2026 18:04

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for requesting the ML-KEM-1024 post-quantum cryptography algorithm. It adds documentation, updates the REST client to prepend MLKEM1024 when the GOOGLE_CLOUD_CPP_ENABLE_ML_KEM_1024 environment variable is set, and includes integration and unit tests. Feedback on the changes suggests using std::rotate for a more efficient in-place element move in ssl_ec_curves.cc, using structured bindings in map loops, and avoiding the use of auto when it obscures StatusOr return types in tests to align with the repository style guide.

Comment thread google/cloud/internal/ssl_ec_curves.cc Outdated
Comment thread ci/showcase/rest_pqc_test.cc Outdated
Comment thread ci/showcase/rest_pqc_test.cc Outdated
Comment thread google/cloud/internal/ssl_ec_curves_test.cc Outdated
@codecov

codecov Bot commented Oct 15, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.50746% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 92.39%. Comparing base (e4357e4) to head (c6f8d7d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
google/cloud/internal/ssl_ec_curves_test.cc 98.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #16571   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files        2266     2266           
  Lines      219458   219516   +58     
=======================================
+ Hits       202771   202828   +57     
- Misses      16687    16688    +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Allow users to opt in to prioritizing MLKEM1024 for REST TLS 1.3 connections via the GOOGLE_CLOUD_CPP_ENABLE_ML_KEM_1024 environment variable, keeping X25519MLKEM768 in the fallback list. Also document how to request ML-KEM-1024 for both REST and gRPC transports.

This branch was successfully deployed

1 active deployment
false — 1cdf1797 Deployed Oct 15, 2026 by colinmoy via Save PR ref #12475
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant