Repository navigation
Conversation
Co-Authored-By: Claude Code <noreply@anthropic.com>
mmicco-godaddy
requested review from
aka-bo
and
a balanced review from Copilot
November 12, 2026 14:11
There was a problem hiding this comment.
🟢 Approval recommended
The review reports no active issues with the .NET 10 and 11 migration.
No open issues 🎉
What changed in this PR
Updates Asherah’s .NET bindings and supporting tooling to target .NET 10 and 11, dropping .NET 8 and 9 support. Encryption and decryption logic remains unchanged.
Changes:
- Updates target frameworks, logging dependencies, SDK setup, and dependency lockfiles.
- Migrates tests to xUnit 4 and Microsoft.Testing.Platform while preserving disabled test parallelization.
- Aligns CI, documentation, interop, and benchmarks with the new targets.
| File | Description |
|---|---|
scripts/test.sh |
Uses the test runner’s --solution syntax. |
README.md |
Updates documented .NET test targets. |
interop/canonical-csharp/CanonicalCsharpProbe.csproj |
Targets .NET 11 for canonical interop. |
global.json |
Selects SDK 11 and Microsoft.Testing.Platform. |
docs/review-2026-05-05-findings.md |
Clarifies historical callback wording only. |
docker/tests.Dockerfile |
Installs .NET 10 and 11. |
CONTRIBUTING.md |
Updates prerequisites and test commands. |
benchmarks/dotnet-bench/Program.cs |
Runs binding benchmarks on .NET 11. |
benchmarks/dotnet-bench/dotnet-bench.csproj |
Updates framework and BenchmarkDotNet preview. |
benchmarks/dotnet-bench-newmetastore/Program.cs |
Runs new-metastore benchmarks on .NET 11. |
benchmarks/dotnet-bench-newmetastore/dotnet-bench-newmetastore.csproj |
Updates framework and BenchmarkDotNet preview. |
benchmarks/dotnet-bench-canonical/Program.cs |
Runs canonical benchmarks on .NET 11. |
benchmarks/dotnet-bench-canonical/dotnet-bench-canonical.csproj |
Updates framework and BenchmarkDotNet preview. |
asherah-dotnet/tests/GoDaddy.Asherah.Encryption.Tests/packages.lock.json |
Refreshes core test dependencies and targets. |
asherah-dotnet/tests/GoDaddy.Asherah.Encryption.Tests/AssemblyInfo.cs |
Uses the new parallelization attribute. |
asherah-dotnet/tests/GoDaddy.Asherah.Encryption.Compat.Tests/packages.lock.json |
Refreshes compatibility test dependencies and targets. |
asherah-dotnet/tests/Directory.Build.props |
Configures executable tests and platform-compatible coverage. |
asherah-dotnet/src/GoDaddy.Asherah.Encryption/packages.lock.json |
Refreshes core package dependencies and targets. |
asherah-dotnet/src/GoDaddy.Asherah.Encryption/AsherahSession.cs |
Clarifies callback comments; no logic changes. |
asherah-dotnet/src/GoDaddy.Asherah.Encryption.Compat/packages.lock.json |
Refreshes compatibility package dependencies and targets. |
asherah-dotnet/README.md |
Updates targets, test setup, and commands. |
asherah-dotnet/docs/troubleshooting.md |
Clarifies repository-root test invocation. |
asherah-dotnet/docs/testing.md |
Updates native-library test instructions. |
asherah-dotnet/docs/getting-started.md |
Documents .NET 10 and 11 targets. |
asherah-dotnet/Directory.Packages.props |
Updates logging, xUnit, and coverage packages. |
asherah-dotnet/Directory.Build.props |
Sets shared .NET 10 and 11 targets. |
.github/workflows/publish-nuget.yml |
Updates SDKs used for publishing. |
.github/workflows/ci.yml |
Updates binding SDKs and adds interop SDK setup. |
.github/workflows/benchmark-setup.yml |
Updates benchmark SDK installation. |
Review effort: Balanced
aka-bo
reviewed
Nov 12, 2026
aka-bo
left a comment
Collaborator
There was a problem hiding this comment.
Nice work. The net10/net11 move and the new test platform look good, and tests pass for me locally on both.
A few things we should address before merge (details inline):
- Logging.Abstractions 11.0.0 on net10
- Version bump for the net8/net9 drop
- The dated findings doc
Co-Authored-By: Claude Code <noreply@anthropic.com>
Co-Authored-By: Claude Code <noreply@anthropic.com>
aka-bo
approved these changes
Nov 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The .NET packages now target net10.0 and net11.0, dropping .NET 8 and 9 support, and update Microsoft.Extensions.Logging.Abstractions to 11.0.0. The encryption and decryption implementation is unchanged; xUnit 4, Microsoft.Testing.Platform, and parallelization changes are test-only. This also updates CI, SDK setup, documentation, interop, and benchmarks, including a BenchmarkDotNet preview for .NET 11. Local lint, unit tests, .NET binding tests, and canonical C# interop tests passed. The optional new-metastore benchmark was not run because its upstream checkout was unavailable.
Release notes reminder
Include the following in the next GitHub Release description:
🤖 Generated with Claude Code