Skip to content

Restore the Knowledge editor writing area and quiet the mode switch - #1468

Merged
jackmusick merged 2 commits into
mainfrom
1465-editor-height
Nov 19, 2026
Merged

jackmusick merged 2 commits into
mainfrom
1465-editor-height

Conversation

@jackmusick

Copy link
Copy Markdown
Collaborator

Summary

Fixes #1465.

Since #1390, the embedded Knowledge document drawer leaves no room to type at 1280×720. The editor had a 160px minimum height at lg, and the new Visual/Markdown row plus the two-row formatting toolbar used all of it. The nightly knowledge-acceptance browser test has failed on this every night since.

  • Writing area restored: the content area fills the editor box again. Add Visual and Markdown modes to the shared editor #1390 had removed flex-1 and the editor's full-height classes.
  • Taller minimum: the editor's minimum height in the embedded drawer goes to 320px at lg. On short windows the drawer's settings region scrolls instead of collapsing the editor. Cancel and Save stay pinned.
  • Quieter mode switch: Visual/Markdown is now a compact segmented control at the end of the formatting toolbar, using a new segmented toggle variant. It no longer takes a row of its own. The toolbar row stays mounted across mode changes, so keyboard focus stays on the switch. The phone tap height stays at 44px.

Verification

  • npm run tsc and eslint on the changed files: no errors
  • ./test.sh client unit for the editor, toolbar, toggle and Knowledge drawer: 42 passed (includes a new check that focus stays on the switch after a mode change)
  • ./test.sh client e2e on knowledge-acceptance, integration-notes and forms-public: 7 passed. knowledge-acceptance now also requires a writing area of at least 120px at 1280×720
  • Checked by hand at 1280×720 and 1440×1000 in Visual and Markdown modes
  • Not run: the full browser suite (the merge queue runs it)

Product Updates: omit (routine bug fix).

🤖 Generated with Claude Code

jackmusick and others added 2 commits November 18, 2026 22:56
…1465)

The embedded Knowledge drawer gave its editor a 160px minimum at lg, and
since #1390 the Visual/Markdown row plus the wrapped toolbar consumed all
of it, leaving no writing area at 1280x720. Restore the content area's
fill behavior, raise the embedded minimum to 320px so the settings region
scrolls instead of collapsing the editor, and move the mode switch into
the toolbar row as a compact segmented control.

Fixes #1465

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@jackmusick
jackmusick added this pull request to the merge queue Nov 19, 2026
Merged via the queue into main with commit d6d6d36 Nov 19, 2026
20 checks passed
@jackmusick
jackmusick deleted the 1465-editor-height branch November 19, 2026 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Knowledge document editor has no writing area in the embedded drawer at 1280×720

1 participant