Repository navigation
Restore the Knowledge editor writing area and quiet the mode switch - #1468
Merged
Merged
Conversation
…1465) The embedded Knowledge drawer gave its editor a 160px minimum at lg, and since #1390 the Visual/Markdown row plus the wrapped toolbar consumed all of it, leaving no writing area at 1280x720. Restore the content area's fill behavior, raise the embedded minimum to 320px so the settings region scrolls instead of collapsing the editor, and move the mode switch into the toolbar row as a compact segmented control. Fixes #1465 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1465.
Since #1390, the embedded Knowledge document drawer leaves no room to type at 1280×720. The editor had a 160px minimum height at
lg, and the new Visual/Markdown row plus the two-row formatting toolbar used all of it. The nightlyknowledge-acceptancebrowser test has failed on this every night since.flex-1and the editor's full-height classes.lg. On short windows the drawer's settings region scrolls instead of collapsing the editor. Cancel and Save stay pinned.segmentedtoggle variant. It no longer takes a row of its own. The toolbar row stays mounted across mode changes, so keyboard focus stays on the switch. The phone tap height stays at 44px.Verification
npm run tscand eslint on the changed files: no errors./test.sh client unitfor the editor, toolbar, toggle and Knowledge drawer: 42 passed (includes a new check that focus stays on the switch after a mode change)./test.sh client e2eonknowledge-acceptance,integration-notesandforms-public: 7 passed.knowledge-acceptancenow also requires a writing area of at least 120px at 1280×720Product Updates:
omit(routine bug fix).🤖 Generated with Claude Code