Repository navigation
Preserve nullable named objects in gRPC collections - #4071
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goa's generated gRPC converters can panic when an
ArrayOforMapOfcontains a null entry for a named object. These entries are valid for nullable collections, but the loops pass nil to private object conversion helpers that require a present object. Inline object collections already preserve these entries in their loops.The generated loops now keep nullable array positions and map keys before calling an object helper, in both conversion directions.
ArrayOfRequiredstill rejects nil entries, and strict helper bodies and required object or union validation are unchanged. This preserves in-memory conversion behavior: binary protobuf still decodes nil message entries as present empty messages, and ProtoJSON still rejects null entries.Generated request and response tests cover populated values around a nil entry, objects with a required union, present empty objects, required-element rejection, and the existing wire behavior. The gRPC generator package tests, focused generator tests with the race detector, and configured lint checks passed with Go 1.27.3.