Repository navigation
Validate selected union branches before checking fields - #4070
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generated Goa validation could accept a union with an unknown branch kind or a selected object branch whose value was nil. When the branch fields had no constraints, validation could succeed even though encoding rejected the same value. Invalid typed values could therefore pass the checks callers use before conversion or encoding.
Both planned and legacy validation now call the generated union's existing
Validatemethod before checking the selected branch's fields, including when those fields have no constraints. Optional value unions with no selection and nil optional pointers remain absent; a present pointer must contain a valid selection. Allocated empty collections still follow their declared length rules. Named and derived union roots use the methods of their underlying generated union.Generated runtime fixtures verify invalid selections, optional absence, empty collections, named roots, and unchanged inputs. Focused validation, view, HTTP, WebSocket, and gRPC checks and affected-package lint passed. Race detection covered the outer generator fixture package; child generated-module checks ran normal tests. The full repository suite was not run. Regenerate affected code to receive the checks.