Repository navigation
Preserve generated option IDs when navigating backwards - #119
Merged
liuliu-dev merged 1 commit intoOct 15, 2026
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The localized cleanup change fixes the reported defect and includes targeted regression coverage.
0 open findings
What changed in this PR
Fixes backward combobox navigation so generated option IDs remain synchronized with aria-activedescendant.
Changes:
- Clears the previous selection before assigning the next option’s ID.
- Reuses existing cleanup logic and removes the duplicated loop.
- Adds a backward-navigation regression test.
| File | Description |
|---|---|
| test/test.js | Verifies generated IDs follow backward selection. |
| src/index.ts | Clears selection before assigning the target ID. |
🧠 Review effort: Max
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
liuliu-dev
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For options without IDs, pressing ArrowDown twice and then ArrowUp leaves
aria-activedescendantpointing at an ID that no longer exists. The previous option still owns the generated ID when the new option is processed.Clear the previous selection before assigning the new option's ID, using the existing cleanup method. This also removes the duplicated cleanup loop.
The Chromium regression fails before the fix and passes after it. All 28 tests from the repository's browser suite pass in an isolated Mocha/Chai Chromium harness; existing ID and collision controls are included. TypeScript compilation and ESLint pass using compatible tools from a sibling checkout. Karma and Firefox/WebKit were not run.