Repository navigation
(Closed MR) - #5944
Closed
a2105z wants to merge 2 commits into
Closed
(Closed MR)#5944a2105z wants to merge 2 commits into
a2105z wants to merge 2 commits into
Conversation
Attach JS-parity cache_control metadata to content and system text blocks, and surface cache creation/read token usage in Custom.
Skip nil content parts and guard applyCacheControl against a nil block.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds ephemeral prompt caching support for the Anthropic Go plugin, mirroring the JS SDK behavior. It introduces cache control helpers, preserves cache metadata on system prompts and user content blocks, and exposes cache usage statistics in the response. The review feedback points out several critical issues regarding potential nil pointer dereferences and map assignment panics in both the production code and tests, which should be addressed to ensure stability.
a2105z
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Closed MR)