Repository navigation
Conversation
Author
|
Hi, could a maintainer approve the CI run for the chart fix when convenient? The CI run for the separate DOCX preview PR #222 is also marked action required with no jobs started. The latest #222 commit adds the two-shape regression requested in review. Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220
Problem
PowerPoint charts may omit a cached numeric point for an empty data cell, or omit a category label while its numeric point remains. Compaction of either list can attach a value to the wrong category or silently drop it.
Change
Match category labels and numeric points using their declared indices. Emit rows for observed indices, including unlabeled rows with data. Treat the first level of a multi-level category cache as its indexed leaf labels. Retain higher-level captions in the existing flattened view without attaching numeric values to them.
Validation
Prepared with Codex assistance.
Summary by cubic
Fixes #220 so sparse chart data in PPTX files stays aligned. Category labels and numeric points are now matched by their declared
idxinstead of list position, preventing values from shifting onto the wrong category or being dropped when PowerPoint omits an empty cell's entry.Multi-level category caches now treat only the first level as indexed leaf labels, so higher-level captions remain in the output without receiving numeric values. Values can also appear on unlabeled rows when a category label is missing.
Written for commit d574792. Summary will update on new commits.