Repository navigation
Fix named instances with built-in object property names - #201
Merged
Tony133 merged 2 commits intoOct 9, 2026
Merged
Conversation
Tony133
approved these changes
Oct 9, 2026
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Named instances currently use a plain object and check
fastify.mysql[name]for duplicates. Names inherited fromObject.prototype, such astoStringandconstructor, are therefore rejected even when unused;__proto__also needs a dictionary without a prototype to work as a key.Use a null-prototype dictionary and check only own properties. Add a regression test for all three names.
I found and fixed the same issue in my MariaDB fork: melroy89/fastify-mariadb#3
Verification
npm run lintnpm run test:typescriptnpm run test:unitagainst isolated MySQL 9.7.2: 43 passed, 100% coverage