Skip to content

[Cisco] Expose BGP build information over Thrift - #13

Closed
selekkala wants to merge 1 commit into
facebook:mainfrom
selekkala:codex/add-bgp-build-info-rpc
Closed

selekkala wants to merge 1 commit into
facebook:mainfrom
selekkala:codex/add-bgp-build-info-rpc

Conversation

@selekkala

Copy link
Copy Markdown

Summary

  • Add the additive TBgpService.getBuildInfo() RPC required by FBOSS PR #1665.
  • Implement the RPC in BgpServiceBase using the running daemon build metadata.
  • Export the build_* keys consumed by the OSS fboss2 show version bgp command.
  • Add unit coverage for the build-info map and service handler.

Integration

This is the daemon-side companion to facebook/fboss#1665. New FBOSS clients can handle older daemons by converting Thrift UNKNOWN_METHOD into an upgrade message; updated daemons serve this RPC. The RPC is additive, so older FBOSS clients remain compatible with updated daemons.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Oct 11, 2026
@selekkala selekkala changed the title Expose BGP build information over Thrift [Cisco] Expose BGP build information over Thrift Oct 11, 2026
@selekkala selekkala closed this Oct 11, 2026
@selekkala
selekkala deleted the codex/add-bgp-build-info-rpc branch October 11, 2026 17:30
@selekkala

Copy link
Copy Markdown
Author

Replaced by BGP PR #14, which uses the renamed add-bgp-build-info-rpc branch without the codex/ prefix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant