Skip to content

In a memory-off turn, the false-claim correction reveals whether a stored memory backs a claim #551

Closed

Description

@itsskofficial

Found while testing #548. #531 corrects a claimed memory save, but it first checks the stored memories: if one backs the claim, the reply is treated as being about an earlier save and left alone.

In a memory-off turn (/v1 with openai_api.allow_memory off, or incognito with memory off) that check acts as a yes/no oracle. With a scripted model, "your dentist is Kulkarni" got no correction and "Mehta" did, so the app can learn what's stored by watching which claims get corrected.

Fix: when memory_allowed is false for the turn, skip the stored-memory check, so the correction depends only on what happened in the turn.

Done when: a test shows both claims get the same treatment in a memory-off turn, and memory-on turns behave as today.

Activity

  1. added
    bugSomething isn't working
    area: engineAgent loop, models, approvals, storage, gateway
    area: memoryFacts, user model, nightly consolidation
    priority: P2Later: useful, lower urgency
    size: SSmall: a few days
    on Nov 7, 2026
  2. G26karthik commented on Nov 7, 2026

    @G26karthik
    Contributor

    /assign

  3. github-actions commented on Nov 7, 2026

    @github-actions

    @G26karthik Assigned to you. Open a PR within a week or comment if you need more time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

area: engineAgent loop, models, approvals, storage, gatewayarea: memoryFacts, user model, nightly consolidationbugSomething isn't workingpriority: P2Later: useful, lower urgencysize: SSmall: a few days

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions