Repository navigation
ci: fix the Update wiki and Build workflows of the wiki branch - #1694
Open
NRGLine4Sec wants to merge 2 commits into
Open
NRGLine4Sec wants to merge 2 commits into
NRGLine4Sec wants to merge 2 commits into
Conversation
mv cannot replace a directory that already exists in the destination, so the first push after images/ reaches the wiki would fail, and every push after it. Copy the pages instead. On pull requests, apply the changes to a clone of the wiki without pushing: a pull request from a fork only gets a read-only token, so the push always failed there. Pushes from forks are skipped too, a push with nothing to change no longer fails on an empty commit, and two merges in a row no longer push at the same time. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The job stopped at its actions/setup-go@v1 step (Go 1.13) on current GitHub runners, so it failed on every pull request, wiki changes included. Use the Go version of master, and allow the build to write the go.sum this branch does not have. Changes under wiki/ cannot affect the build and no longer trigger it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the two workflows of the
wikibranch, which fail on every pull request to it (#1600 had both failures, and so does #1693).Update wiki
mv -f wiki/* opensnitch.wiki/cannot replace a directory that already exists in the wiki. Today the wiki has no directory, but wiki: document inbound port scan detection #1693 addswiki/images/: once it is merged, the next push towikiwould fail withmv: cannot overwrite 'opensnitch.wiki/images': Directory not empty, and so would every push after it, whatever page it changes. The pages are now copied withcp -R wiki/. opensnitch.wiki/, which updates existing directories.git statusstill show whether the change applies.wikiinevilsocket/opensnitch, so a fork's own pushes no longer try to write to this wiki.git commit.actions/checkout@v2becomes@v4, and the workflow file itself is part of the trigger paths.Build
The job stops at its
actions/setup-go@v1step (Go 1.13) on current GitHub runners. The job now usesactions/setup-go@v5with Go 1.23, the version used bymaster, and builds with-mod=modbecause this branch has nogo.sum. Changes underwiki/cannot affect the build, so they no longer trigger it.Checked
-mod=mod(without-mod=modit stops onmissing go.sum entry).images/created), then the same content again withimages/present ("already up to date", no failure), then a page edit plus a new image (2 files changed). The originalmvfails on the second case.This PR and #1693 can be merged in either order. Without this one, the first change to the wiki after #1693 fails.
🤖 Generated with Claude Code